Remove remaining const_casts from CombinedMuonTrackBuilder

None of the the const_casts involved objects from SG. One was totally unnecessary, and the others were only needed because CombinedMuonTrackBuilder was using ITrackFitter interfaces, which assumed const tracks. As it turns out, there is only one case in which the ITrackFitter interface to the CombinedMuonTrackBuilder was actually used, by the MuonSegmentRegionRecoveryTool, which uses the global chi2 fitter in EO-only mode, and the CombinedMuonTrackBuilder otherwise. So a CombinedMuonTrackBuilder ToolHandle has been added to the MuonSegmentRegionRecoveryTool, and the configuration updated appropriately. Depending on whether m_onlyEO is true or false, the appropriate tool is retrieved and used in the fit. The interfaces in ICombinedMuonTrackBuilder are now non-const in cases where a const track is not expected, and the const_casts have been removed.

Closes ATLASRECTS-1973

WARNING: big files (>100K) are found in the changeset

204K in file Reconstruction/MuonIdentification/MuidTrackBuilder/src/CombinedMuonTrackBuilder.cxx

This merge request affects 5 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuidInterfaces
• Reconstruction/MuonIdentification/MuidTrackBuilder
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Reconstruction/MuonIdentification/MuonCombinedRecExample

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash a55c5d40)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15926]

Hi, looks good thus approving. L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 49e55d61

added sweep:ignore label