Skip to content
Snippets Groups Projects

MM geometry fixes

Merged Chara Kitsaki requested to merge ckitsaki/athena:fixMMgeom into 21.3

This MR deals with:

  1. new stations.v2.08.xml/stations.v2.08_Aside.xml:
  • MM: The proper values of the top/bottom frames (ie frame+empty space due to missing strips) are updated.
  • MM: The active areas are expanded by 1pitch in total, to include the whole strips in the active volume.
  1. In the MMReadoutElement:
  • The active areas are moved by half difference of the top/bottom frames and are placed at the center of the quadruplet.
  • localToGlobalCoords() returns correctly the positions in the global ATLAS reference frame
  1. In the sTgcReadoutElement:
  • add stripGlobalPosition() returns the strip position in ATLAS global reference frame
  • localToGlobalCoords() returns correctly the positions in the global ATLAS reference frame
  1. In Micromegas.cxx / sTGC.cxx of the MuonGeoModel, the correct frame parameters are initialized and used depending on the module.

adding @alaurier, @rosati and @nkoehler

Edited by Chara Kitsaki

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chara Kitsaki added 2 commits

    added 2 commits

    Compare with previous version

  • Chara Kitsaki added 151 commits

    added 151 commits

    Compare with previous version

  • Chara Kitsaki changed title from WIP: Fix m mgeom to WIP: MM geometry fixes

    changed title from WIP: Fix m mgeom to WIP: MM geometry fixes

  • Chara Kitsaki changed the description

    changed the description

  • Chara Kitsaki removed alsoTargeting:21.9 + 1 deleted label

    removed alsoTargeting:21.9 + 1 deleted label

  • Chara Kitsaki added 135 commits

    added 135 commits

    Compare with previous version

  • Chara Kitsaki changed the description

    changed the description

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Chara Kitsaki added 1 commit

    added 1 commit

    • b782289d - dump the correct frames in MuonGeoModel

    Compare with previous version

  • Chara Kitsaki changed the description

    changed the description

  • Alexandre Laurier resolved all threads

    resolved all threads

  • Nicolas Koehler changed the description

    changed the description

  • added alsoTargeting:21.9 + 1 deleted label

  • Chara Kitsaki unmarked as a Work In Progress

    unmarked as a Work In Progress

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 112K in file MuonSpectrometer/MuonG4/NSW_Sim/data/stations.v2.08_Aside.xml

    :pencil: 108K in file MuonSpectrometer/MuonG4/NSW_Sim/data/stations.v2.08.xml

  • This merge request affects 6 packages:

    • MuonSpectrometer/MuonDetDescr/MuonAGDDBase
    • MuonSpectrometer/MuonDetDescr/MuonAGDDDescription
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonDigitization/MM_Digitization
    • MuonSpectrometer/MuonG4/NSW_Sim
    • MuonSpectrometer/MuonGeoModel

    Adding @jchapman ,@rosati ,@wleight ,@nkoehler as watchers

  • :white_check_mark: CI Result SUCCESS (hash b782289d)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 157
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44925]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading