TrkVertexFitters add ATLAS_CHECK_THREAD_SAFETY
- Remove some un-needed const_cast
- Remove commented out code
- The
DummyVertexSmoother
has a const_cast. So marked as not thread safe.
In case the Dummy
is actually used in production (@kostyuk , @vcairo ?), the issue is that the Extrapolator returns ptr to const TrackParameters (in cases it could prb be avoided ). Although the caller takes ownership in terms of deleting them , this const_cast
is needed. In many cases we managed to move tools to non-const unique_ptr
but not this case. Anyhow, in worse case we can clone. But 1st the question is if the Dummy
is really used..
Edited by Christos Anastopoulos