add ATLAS_CHECK_THREAD_SAFETY to TrkVertexWeightCalculators

• Make IVertexWeightCalculator const (i.e methods are const)
• Make the implementations const
• Then add ATLAS_CHECK_THREAD_SAFETY to the implementations.
• Also add the new style logging
• And removed some quite old conventions (parts of these tools seem to be not really have been touched for quite some time)

The NN implementation was not thread safe.

The problematic line was

m_NN = m_networkToHistoTool->fromHistoToTrainedNetwork(m_NNhistos);

Now this is done at the end of initialize ...

changed the description

This merge request affects 2 packages:

• Tracking/TrkVertexFitter/TrkVertexFitterInterfaces
• Tracking/TrkVertexFitter/TrkVertexWeightCalculators

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

changed the description

added 1 commit

• 34736f6e - make NN also thread safe

Compare with previous version

This merge request affects 2 packages:

• Tracking/TrkVertexFitter/TrkVertexFitterInterfaces
• Tracking/TrkVertexFitter/TrkVertexWeightCalculators

Adding @amorley as watcher

CI Result SUCCESS (hash 34736f6e)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16587]

CI Result SUCCESS (hash 9005a020)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16586]

added 1 commit

• 70528e3d - Actually add the ATLAS_CHECK_THREAD_SAFETY file ...

Compare with previous version

This merge request affects 2 packages:

• Tracking/TrkVertexFitter/TrkVertexFitterInterfaces
• Tracking/TrkVertexFitter/TrkVertexWeightCalculators

Adding @amorley as watcher

CI Result SUCCESS (hash 70528e3d)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16610]

Few minor comments....

Pavol [as L2 MR shifter]

added review-user-action-required label

added 1 commit

• a5922258 - ATH_CHECK, Gaudi Units

Compare with previous version