TrigSteeringEvent: Enable thread checker and fix warnings

Enable static thread checker and fix warnings. Also remove some unprotected DEBUG messages.

This merge request affects 4 packages:

• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TrigEvent/TrigSteeringEventAthenaPool
• Trigger/TrigEvent/TrigSteeringEventTPCnv
• Trigger/TrigEvent/TrigStorageDefinitions

Adding @rbielski as watcher

added Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash f38c92ab)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16775]

The changes look good to me, and CI passes. Approving. (warning is not related)

Xiaozhong (L1)

added review-approved label and removed review-pending-level-1 label

added 2 commits

• 1d611795 - TrigSerializeResult: Enable thread checker
• 35f1be73 - TrigSerializeCnvSvc: Enable thread checker and fix warnings

Compare with previous version

added 44 commits

• 35f1be73...81dd0301 - 40 commits from branch atlas:master
• 0cc0b975 - TrigSteeringEvent: Enable thread checker and fix warnings
• 64c8ea25 - TrigSteeringEventAthenaPool: Enable thread checker
• 83dfa651 - TrigSteeringEventTPCnv: Enable thread checker and fix warnings
• ed50b6bf - TrigStorageDefinitions: Enable thread checker

Compare with previous version

Accidentally pushed new commits to this branch after it was approved. I removed them again...

This merge request affects 4 packages:

• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TrigEvent/TrigSteeringEventAthenaPool
• Trigger/TrigEvent/TrigSteeringEventTPCnv
• Trigger/TrigEvent/TrigStorageDefinitions

Adding @rbielski as watcher

added review-pending-level-1 label and removed review-approved label

This merge request affects 4 packages:

• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TrigEvent/TrigSteeringEventAthenaPool
• Trigger/TrigEvent/TrigSteeringEventTPCnv
• Trigger/TrigEvent/TrigStorageDefinitions

Adding @rbielski as watcher

CI Result FAILURE (hash 35f1be73)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16835]

CI Result FAILURE (hash ed50b6bf)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16836]

added 1 commit

• 064a6c8f - TrigSteeringEvent: Mark HLTResult::getExtraData as not threads-safe

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TrigEvent/TrigSteeringEventAthenaPool
• Trigger/TrigEvent/TrigSteeringEventTPCnv
• Trigger/TrigEvent/TrigStorageDefinitions

Adding @rbielski as watcher

CI Result SUCCESS (hash 064a6c8f)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16937]

Now all look good, approving.

added review-approved label and removed review-pending-level-1 label

mentioned in commit 3e4c815f

merged