TrigL1CaloUpgrade: eFEX egamma update

@bcarlson @viveiros

Updates to e/gamma algorithm (or any other based in TrigT1CaloBaseFex)

• update seeding algorithm to match firmware
  • unlikely user will see any effect
• update handling of regions with unusual supercell geometry (1.4-1.5, 1.8-2.0, 2.4-2.5)
  • some visible changes in all algorithm aspects around barrel-endcap transition
  • visible changes in L1Width in regions 1.8-2.0, 2.4-2.5
  • RetaL12 will also change for |eta|>2.3
• update L1Width with integer weights and special handling of 1.8-2.0 region
  • large change in scale of variable
  • 1.8-2.0 no longer has narrower distribution than the norm (as does not use finer granularity than will be available in reality)
• update RHad algorithm to match the clusters used in the firmware
  • modest changes in values

For reference, here is a summary: https://indico.cern.ch/event/939184/contributions/3946427/attachments/2073972/3482312/egamma_Simulation_Update.pdf

This merge request affects 1 package:

• Trigger/TrigL1Upgrade/TrigL1CaloUpgrade

Adding @kwhalen as watcher

added 21.3 Trigger review-pending-level-1 labels

CI Result SUCCESS (hash cfec7257)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST 44366]

added review-pending-level-2 label and removed review-pending-level-1 label

added review-pending-expert label and removed review-pending-level-2 label

added review-pending-level-1 label and removed review-pending-expert label

Sorry for messing up with labels. The UI is ab it awkward. Anyways, there are compilation warnings sending back to L1.

warning: unused parameter 'Isovalue' [-Wunused-parameter] in Trigger/TrigL1Upgrade/TrigL1CaloUpgrade

added Run3L1Calo alsoTargeting:21.9 labels

added urgent label

added review-approved label and removed review-pending-level-1 label

The code changes are ok from L1 review perspective. But there are warnings. Unused variables. @watsona can you please fix them.

added review-user-action-required label and removed review-approved label

@watsona just a gentle reminder to resolve the unused variable warning, Cheers (L1)

I'll see what I can do, though I'll note that none of those warnings are in the single class that I modified, so they must all be in the current release and passed previous approval.

I am currently working on the same piece of code, and can also confirm that the warnings are already there.

Maybe in the interest of time, as this work from Alan is urgently needed, we could approve this and I can try to fix this in the next round. Unless Alan wants to fix this here.

I would support the proposal from Joerg... Let's merge this then fix the existing warnings later. Thanks.

Ok, Alan said he is fixing it already...

Well I was trying to fix it. The fix is easy, committing it is not. I think this is probably because I based my branch for this MR on the athena directory in my project, while these errors come from the NtupleDumper in Ben's R3AthAnalysis package which is in source/NtupleDumper rather than source/athena, and hence it won't update to my branch (sorry if that explanation is mangled, not that experienced with git yet).

Unless someone knows some magic this might be most easily dealt with via a separate MR.