LArCellRec: Fix clang 10 warning.

Avoid spurious object copy in range for.

This merge request affects 1 package:

• LArCalorimeter/LArCellRec

Adding @pavol as watcher

added JetEtmiss LAr master review-pending-level-1 labels

CI Result FAILURE (hash 9b358489)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16898]

Hi @ssnyder , this is more for my info and is a bit special on the Identifiers. I have seen this issue when I run clang-tidy . What I found a bit confusing is that the Identifier is an int so was not always obvious to me if the complain is valid or if is not clear that this is a int or something else ?

Yeah, for Identifier it shouldn't really make a difference. Depending on what happens in the loop, the code generated might even be the same for the two cases.

But it's probably better to have a general rule about classes than have a list of exceptions. (And more practically, there's no easier way to shut up the compiler's warning.)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit a71b12cb

added sweep:ignore label