Skip to content
Snippets Groups Projects

Update tau trigger cluster orientation

Merged Nicholas Luongo requested to merge nicholas/athena:21.3 into 21.3

Change tau trigger to use only L2 calorimeter layer for phi orientation, update isolation criteria, and fix python config script

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor

    Only one minor commented out line. Beyond that, if there are any references available for these hardcoded isolation cuts (e.g. studies on indico) it would be good to link them in a comment.

    Jon (L1)

  • added 1 commit

    • 28b10e2f - Remove comment line and add isolation reference

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigL1Upgrade/TrigL1CaloUpgrade

    Adding @kwhalen as watcher

  • :white_check_mark: CI Result SUCCESS (hash 28b10e2f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 44602]

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigL1Upgrade/TrigL1CaloUpgrade

    Adding @kwhalen as watcher

  • :white_check_mark: CI Result SUCCESS (hash 7db131e2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 44616]

  • Changes look good, approving.

  • John Derek Chapman resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading