Continues to move tests from TrigUpgraTest to better suited packages

Moving Calo tests from TrigUpgradeTest to TrigT2CaloCommon. Discussed in ATR-21713. Sure that @fpastore and @tbold should give this a look (first time I change these tests). Not sure about reference updates (is that needed?). Denis

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @okumura ,@joheinri ,@damazio ,@jpanduro as watchers

added Trigger master review-pending-level-1 labels

Hmm, Wait. "first time" makes me wonder if you need these tests for calo development at all?

No.. I mean it is the first time I change these tests, but I use their results since long.. don’t confuse!! I don’t care about IDCalo.. we could remove..

thanks Denis, seems fine

CI Result FAILURE (hash fc7eee25)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17565]

Should TrigT2CaloCommon_TestService_ctest fail?

added review-user-action-required label and removed review-pending-level-1 label

I don't know why it started to fail. I think it is independent cause. Let me check..

The crash seems in some unrelated thing.. How do I know if this test is working in the nightly? Cheers, Denis Event counter: 2 Slot 0 : Current algorithm = DecisionSummaryMakerAlg : Last Incident = BeginIncFiringAlg:BeginEvent : Event ID = [327265,186524665,t:1497896168.184074160,l:100,b:3284]

Maybe @rbielski could help to define the guilt one here?! Or @fpastore ....?

See https://its.cern.ch/jira/browse/ATR-21780

Should be fixed by !35018 (merged)

On the other hand, it's not a great idea to run a full HLT job as a unit test. That depends on large number of components from other packages, so is really an opposite of testing a "unit". A job running just the relevant parts (calo) would be more appropriate. What's the purpose of running DecisionSummaryMakerAlg in a calo unit test?

Check the performance of Hltcalo tools with respect to all others? But then, the failure in the test is irrelevant to the issue in hand and this MR should be accepted? Denis

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @okumura ,@joheinri ,@damazio ,@jpanduro as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash fc7eee25)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17724]

Same test still irrelevant...

Should I try once more?!

As long as the test will not be fixed, retries will not help.

But the test failing is unrelated to this package, to this request...

Also, how do I check if this test is also failing in the nightly?!

Hi @damazio - here http://test-atrvshft.web.cern.ch/test-atrvshft/ART_monitor/Monitor/Build/2020-07-25T2137/master_Athena_x86_64-centos7-gcc8-opt?package=TriggerTest&comparisonTo=0

I fixed it but not in time for yesterday's build. Will be fixed in the Sunday evening nightly build.

Restarting CI here

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @okumura ,@joheinri ,@damazio ,@jpanduro as watchers

CI Result SUCCESS (hash fc7eee25)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17803]

The changes look fine and the CI issue is unrelated. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

resolved all threads

merged

mentioned in commit bc9f77e8

added sweep:ignore label