TrigT1: Fixes for thread checker

Enable thread checker for several packages under Trigger/TrigT1. Mostly trivial fixes. Also delete unused LVL1CTP::TMUtil class.

This merge request affects 14 packages:

• Trigger/TrigT1/L1Common
• Trigger/TrigT1/TrigT1CaloCalibAthenaPool
• Trigger/TrigT1/TrigT1CaloCalibToolInterfaces
• Trigger/TrigT1/TrigT1CaloCalibTools
• Trigger/TrigT1/TrigT1CaloCalibUtils
• Trigger/TrigT1/TrigT1CaloEvent
• Trigger/TrigT1/TrigT1CaloMonitoringTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TrigT1/TrigT1CaloUtils
• Trigger/TrigT1/TrigT1EventTPCnv
• Trigger/TrigT1/TrigT1Interfaces
• Trigger/TrigT1/TrigT1MuctpiPhase1
• Trigger/TrigT1/TrigT1ResultByteStream

Adding @kwhalen ,@afaulkne as watchers

added DQ Trigger master review-pending-level-1 labels

CI Result FAILURE (hash b7ed2420)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17574]

Jenkins please retry a build

This merge request affects 14 packages:

• Trigger/TrigT1/L1Common
• Trigger/TrigT1/TrigT1CaloCalibAthenaPool
• Trigger/TrigT1/TrigT1CaloCalibToolInterfaces
• Trigger/TrigT1/TrigT1CaloCalibTools
• Trigger/TrigT1/TrigT1CaloCalibUtils
• Trigger/TrigT1/TrigT1CaloEvent
• Trigger/TrigT1/TrigT1CaloMonitoringTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TrigT1/TrigT1CaloUtils
• Trigger/TrigT1/TrigT1EventTPCnv
• Trigger/TrigT1/TrigT1Interfaces
• Trigger/TrigT1/TrigT1MuctpiPhase1
• Trigger/TrigT1/TrigT1ResultByteStream

Adding @kwhalen ,@afaulkne as watchers

CI Result FAILURE (hash b7ed2420)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17665]

Jenkins please retry a build

This merge request affects 14 packages:

• Trigger/TrigT1/L1Common
• Trigger/TrigT1/TrigT1CaloCalibAthenaPool
• Trigger/TrigT1/TrigT1CaloCalibToolInterfaces
• Trigger/TrigT1/TrigT1CaloCalibTools
• Trigger/TrigT1/TrigT1CaloCalibUtils
• Trigger/TrigT1/TrigT1CaloEvent
• Trigger/TrigT1/TrigT1CaloMonitoringTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TrigT1/TrigT1CaloUtils
• Trigger/TrigT1/TrigT1EventTPCnv
• Trigger/TrigT1/TrigT1Interfaces
• Trigger/TrigT1/TrigT1MuctpiPhase1
• Trigger/TrigT1/TrigT1ResultByteStream

Adding @kwhalen ,@afaulkne as watchers

CI Result SUCCESS (hash b7ed2420)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17676]

Hello Frank,

The CI make gives a warning: /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigT1/TrigT1CaloCalibUtils/src/L1CaloPprPhos4ShapeMaker.cxx:438:45: warning: Function 'virtual StatusCode L1CaloPprPhos4ShapeMaker::finalize()' calling 'not_reentrant' function 'StatusCode L1CaloPprPhos4ShapeCollection::Finalize()' must also be 'not_reentrant'. StatusCode sc = m_signalShapes->Finalize();

Would you be able to take a look?

added review-user-action-required label

removed review-pending-level-1 label

added 121 commits

• b7ed2420...7c584f97 - 115 commits from branch atlas:master
• 8a9262b3 - TrigT1: Enable thread checker for "clean" packages
• d8ffef67 - TrigT1Interfaces: Fixes for thread checker
• dc8ac263 - TrigT1CaloUtils: const fixes, enable thread checker
• a2654fd8 - TrigT1CaloCalibUtils: const fixes, enable thread checker
• 61d2c7ab - TrigT1CaloCalibTools: fixes for thread checker
• 13aaba02 - TrigT1CaloCalibUtils: Mark finalize as ATLAS_NOT_THREAD_SAFE

Compare with previous version

This merge request affects 14 packages:

• Trigger/TrigT1/L1Common
• Trigger/TrigT1/TrigT1CaloCalibAthenaPool
• Trigger/TrigT1/TrigT1CaloCalibToolInterfaces
• Trigger/TrigT1/TrigT1CaloCalibTools
• Trigger/TrigT1/TrigT1CaloCalibUtils
• Trigger/TrigT1/TrigT1CaloEvent
• Trigger/TrigT1/TrigT1CaloMonitoringTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TrigT1/TrigT1CaloUtils
• Trigger/TrigT1/TrigT1EventTPCnv
• Trigger/TrigT1/TrigT1Interfaces
• Trigger/TrigT1/TrigT1MuctpiPhase1
• Trigger/TrigT1/TrigT1ResultByteStream

Adding @kwhalen ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 13aaba02)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17741]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit f03ea9e3

added sweep:ignore label