Skip to content
Snippets Groups Projects

METReconstruction: First attempt at preparing the MET Reconstruction code for the run III configuration system

Merged METReconstruction: First attempt at preparing the MET Reconstruction code for the run III configuration system
williams/athena:METcfgdevSept2019 into master
All threads resolved!
Merged Sarah Louise Williams requested to merge williams/athena:METcfgdevSept2019 into master
All threads resolved!

Move legacy run II configuration code into new subdirectory of python to avoid confusion. Create new file (METReconstruction/share/METRecConfig.py ) to allow standalone testing of the new configuration code. Additional cleanup to move initialisation of private ToolHandles into header files in METReconstruction package. Tier0 tests have been checked offline Next steps will involve further work on the new configuration system

Merge request reports

Pipeline #1881557 failed

Stage: external

    Pipeline failed for e8e16f97 on williams:METcfgdevSept2019

    Approval is optional

    Merged by Edward MoyseEdward Moyse 4 years ago (Aug 21, 2020 9:28am UTC)

    Merge details

    • Changes merged into master with ff67a66e.
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 833f1ef9)

    Athena AthSimulation AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :warning: :warning: :warning:
    make :warning: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17662]

  • Tadej Novak added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Sarah Louise Williams added 1 commit

    added 1 commit

    • 2411e5e4 - Fixes to MR: move ToolHandles and ReadHandleKeys to header files and declare as properties

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Control/AthenaConfiguration
    • Reconstruction/Jet/JetRecConfig
    • Reconstruction/MET/METReconstruction
    • Reconstruction/MET/METUtilities

    Adding @goetz ,@ssnyder as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 2411e5e4)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17966]

  • Ahmed Hasib added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Sarah Louise Williams added 1 commit

    added 1 commit

    • 2bad013e - Fixing indents in JetDefinition.py

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Control/AthenaConfiguration
    • Reconstruction/Jet/JetRecConfig
    • Reconstruction/MET/METReconstruction
    • Reconstruction/MET/METUtilities

    Adding @goetz ,@ssnyder as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 2bad013e)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18027]

  • Ahmed Hasib
    Ahmed Hasib @ahasib ·

    Hi @williams, please resolve the threads you have already addressed if everyone is happy. For now I'm changing the label to user-action-required. EDIT: sorry I forgot to mention about the several test failures inculding unit tests for JetRecConfig_JetRecCfgTest_ctest Cheers,

    Hasib (L1)

    Edited by Ahmed Hasib
  • Ahmed Hasib added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Sarah Louise Williams added 1004 commits

    added 1004 commits

    Compare with previous version

    Toggle commit list
  • Sarah Louise Williams resolved all threads

    resolved all threads

  • W
    Sarah Louise Williams @williams ·
    Author Developer

    Hi @ahasib , Tagging @goetz and @mhodgkin , I have remerged here, and think I have fixed most of the weird things going on (at least as of a week or so ago). It doesn't seem to have updated the label, and I was wondering if I am missing something? Sarah

  • Mark Hodgkinson
    Mark Hodgkinson @mhodgkin ·
    Developer

    Hi @williams

    You need to use the "Edit" button next to "Labels" to update the labels yourself. I assume you want to remove revier-user-action-required and add back the L1 review label?

    Cheers,

    Mark

  • Teng Jian Khoo
    Teng Jian Khoo @khoo ·
    Developer

    The commit should have triggered the bot to start the CI, though -- unless it was during the downtime?

  • Teng Jian Khoo
    Teng Jian Khoo @khoo ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • Reconstruction/MET/METReconstruction
    • Reconstruction/MET/METUtilities

    Adding @goetz ,@ssnyder as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 366225e7)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18990]

  • P
    Pienpen Seema @pseema ·

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • Reconstruction/MET/METReconstruction
    • Reconstruction/MET/METUtilities

    Adding @goetz ,@ssnyder as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 366225e7)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19063]

  • W
    Sarah Louise Williams @williams ·
    Author Developer

    Hi all. It seems to be failing on this: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G8AthenaOpt/NICOS_TestLog_MR-35036-2020-08-20-11-58/ReleaseTests___Trigger_athena_MC-test__Trigger_athena_MC-test__m.html But I am really unsure how my changes could be impacting this?

  • P
    Pienpen Seema @pseema ·

    Hi @williams , yes, you are right. There were 2 test failures, one is in the q43 test and another in the MC trigger test. We have been asked to restart CI to all the MRs with q43 failure. And now there is only one failure in the MC trigger that is still under investigation, but we could proceed with reviewing. Pienpen (L1)

  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Sarah Louise Williams added 798 commits

    added 798 commits

    Compare with previous version

    Toggle commit list
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • Reconstruction/MET/METReconstruction
    • Reconstruction/MET/METUtilities

    Adding @goetz ,@ssnyder as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Sarah Louise Williams resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash e8e16f97)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19117]

  • Johannes Junggeburth added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse added NewConfig label

    added NewConfig label

  • E
    Edward Moyse @emoyse ·
    Owner

    Just a comment: Reconstruction/MET/METReconstruction/share/METRecCfg.py

    Normally I wouldn't expect to see new configuration under share/ ... this is all commented out, but when it isn't, it should be under python. Anyway, not worth blocking this for.

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit ff67a66e

    mentioned in commit ff67a66e

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply