Skip to content

TriggerMenuMT: Drop UserList inheritance from StreamInfo

Rafal Bielski requested to merge rbielski/athena:streaminfo-no-list into master

Run-2 StreamInfo was a list, so the Run-3 version was initially implemented as an extension of the UserList class for similar interface. For py2-py3 compatibility this had to be imported from future/six which doesn't come for free and may actually be problematic (see !33636 (merged), ATR-20879). There was actually never any good motivation for StreamInfo to have a list interface, so dropping it here. There is no client relying on this interface.

Other minor changes:

  • make data a private member __data
  • assert argument types in __init__ to catch possible bugs early
  • fix formatting/ordering of the stream definitions (please use diff view with whitespace changes ignored for review)

Merge request reports