Skip to content
Snippets Groups Projects

Move muon trigger atr21822

Merged Move muon trigger atr21822
dbakshig/athena:moveMuonTrigger_ATR21822 into master
All threads resolved!
Merged Debottam Bakshi Gupta requested to merge dbakshig/athena:moveMuonTrigger_ATR21822 into master
All threads resolved!

Hi as discussed in ATR-21822, this MR is made to move some validated muon chains from LS2 to Physics and some test muon chains from Physics to LS2. The moves chains are following if people (adding @sshaw ,@nakahama ,@ckaldero , @markowen ,@vcroft ) agree I will remove the MR.

LS2 to Physics

ChainProp(name='HLT_2mu15_L12MU10', groups=SingleMuonGroup),
ChainProp(name='HLT_3mu8_msonly_L13MU6', groups=SingleMuonGroup),
ChainProp(name='HLT_mu80_L1MU20', groups=SingleMuonGroup),
ChainProp(name='HLT_mu60_L1MU20', groups=SingleMuonGroup),
ChainProp(name='HLT_mu10_lateMu_L1MU10', l1SeedThresholds=['FSNOSEED'], groups=SingleMuonGroup),
ChainProp(name='HLT_mu0_muoncalib_L1MU4_EMPTY', groups=SingleMuonGroup),
ChainProp(name='HLT_mu0_muoncalib_L1MU20',	groups=SingleMuonGroup),
ChainProp(name='HLT_mu22_mu8noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu20_2mu4noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu24_mu10noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu26_mu8noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu26_mu10noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu28_mu8noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu22_2mu4noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_mu24_2mu4noL1_L1MU20', l1SeedThresholds=['MU20','FSNOSEED'], mergingStrategy='serial', groups=MultiMuonGroup),
ChainProp(name='HLT_2mu6Comb_L12MU6', l1SeedThresholds=['MU6'],   groups=MultiMuonGroup),

Physics to LS2

ChainProp(name='HLT_2mu6Comb_L12MU6', l1SeedThresholds=['MU6'],   groups=MultiMuonGroup),
Edited by Debottam Bakshi Gupta

Merge request reports

Pipeline #1872138 failed

Stage: external

    Pipeline failed for 53777e67 on dbakshig:moveMuonTrigger_ATR21822

    Approval is optional

    Merged by Edward MoyseEdward Moyse 4 years ago (Aug 19, 2020 12:58pm UTC)

    Merge details

    • Changes merged into master with c68531bf.
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Debottam Bakshi Gupta added 1 commit

    added 1 commit

    • 3562bdab - moving chains around LS2_v1.py to Physics_pp_run3_v1.py and vice-versa

    Compare with previous version

  • D
    Debottam Bakshi Gupta @dbakshig ·
    Author Developer

    Hi @sshaw ,

    Thanks for checking, I did the correction you suggested, do you think its ready to go or have any suggestion to organize the chains so it looks less cluttered?

    Thanks, Debo.

  • Savanna Shaw resolved all threads

    resolved all threads

  • S
    Savanna Shaw @sshaw ·
    Developer

    Thanks, Debo!

    From my side it's fine.

  • Debottam Bakshi Gupta added 348 commits

    added 348 commits

    • 3562bdab...2b58a449 - 344 commits from branch atlas:master
    • 0569ec28 - Merge remote-tracking branch 'upstream/master' into moveMuonTrigger_ATR21822
    • e1471b1a - moving invm triggers to physics and adding a new invm in LS2 to be tested for primary
    • 19ff72ac - Merge remote-tracking branch 'upstream/master' into moveMuonTrigger_ATR21822
    • 5b646263 - few more LS2 to Physics and vice-versa migration and updating reference

    Compare with previous version

    Toggle commit list
  • Debottam Bakshi Gupta unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Debottam Bakshi Gupta changed the description

    changed the description

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 144K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

    :pencil: 148K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @okumura ,@bernius ,@jpanduro as watchers

  • ATLAS Robot added Trigger TriggerMenu master review-pending-level-1 labels

    added Trigger TriggerMenu master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 5b646263)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18623]

  • Johannes Junggeburth added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Developer

    Hi @dbakshig , this MR has developed some conflicts. Could you please fix them? Thanks.

  • Vakhtang Tsulaia added review-user-action-required label

    added review-user-action-required label

  • Debottam Bakshi Gupta added 105 commits

    added 105 commits

    • 5b646263...dfae668e - 103 commits from branch atlas:master
    • f7c50f8d - Merge remote-tracking branch 'upstream/master' into moveMuonTrigger_ATR21822
    • 3fed5479 - updating references

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 144K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

    :pencil: 148K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @okumura ,@bernius ,@jpanduro as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-approved review-user-action-required labels

    added review-pending-level-1 label and removed review-approved review-user-action-required labels

  • D
    Debottam Bakshi Gupta @dbakshig ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 3fed5479)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18693]

  • Clara Nellist added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Heather Russell
  • D
    Debottam Bakshi Gupta @dbakshig ·
    Author Developer

    Hi @hrussell

    Sure I will.

    Thanks, Debo

  • Debottam Bakshi Gupta added 1 commit

    added 1 commit

    • 7232cdd2 - rmoving redundant row from TopoAlgoDefMultiplicity.py

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 144K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

    :pencil: 148K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @okumura ,@bernius ,@jpanduro as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 7232cdd2)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18729]

  • Debottam Bakshi Gupta added 91 commits

    added 91 commits

    • 7232cdd2...a7ffc841 - 90 commits from branch atlas:master
    • 53777e67 - Merge remote-tracking branch 'upstream/master' into moveMuonTrigger_ATR21822

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 144K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

    :pencil: 148K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @okumura ,@bernius ,@jpanduro as watchers

  • M
    Mark Andrew Owen @markowen ·
    Developer

    @dbakshig, looking at the last CI, the failure in the unit test I think is ok (http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G8AthenaOpt/NICOS_TestLog_MR-35390-2020-08-15-00-36/ReleaseTests___unit-tests__unit-tests__m.html) - it is a timeout seem in other CIs. There does seem to be a real failure in the v7Primaries test, let's see how that comes out with your latest push.

    Mark

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 53777e67)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18832]

  • D
    Debottam Bakshi Gupta @dbakshig ·
    Author Developer

    Hi @markowen ,

    its only timeout error now

  • Debottam Bakshi Gupta resolved all threads

    resolved all threads

  • M
    Mark Andrew Owen @markowen ·
    Developer

    Thanks @dbakshig. For reviewers - the unit test timeout is a known problem (see e.g. https://its.cern.ch/jira/browse/ATEAM-639).

    Mark

  • Magdalena Slawinska added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit c68531bf

    mentioned in commit c68531bf

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply