WIP: ATR-21850 - fixing remaining bugs

Comment out other chains for which Topo algorithms are not migrated and also fix remaining bugs with respect to ATR-21624.

What's your intention with this? Is this supposed to be un-WIPed?

added 1 commit

• 0ee8acf9 - Updates

Compare with previous version

added 1 commit

• c6ec4ea8 - Fixing remaining items

Compare with previous version

Hi @fwinkl

I had other errors to fix. Once they are fixed, I will. It should go together with other one you reverted. Errors are described in JIRA, and I put this WIP MR to share code changes.

Lidija

@lidiaz I did not revert anything yet. Could you make sure you finish this MR here within the next 1-2 hours. We really need to make sure to get this into the nightly.

Almost there. Just to run tests.

added 1 commit

• fb85a369 - ATR-21850 and ATR-21624: Fixing remaining items

Compare with previous version

added 2 commits

• bc9b2868 - ATR-21850 and ATR-21624: Fixing remaining items
• 55dd4c3e - ATR-21850 and ATR-21624: Fixing remaining items

Compare with previous version

added 1 commit

• e037ed90 - ATR-21850 and ATR-21624: Fixing remaining items

Compare with previous version

Hi @fwinkl

Code with my changes compiles and passes CI test locally, but when running it fails with the following:

10:21:44 LVL1ConfigSvc ERROR Standard C++ exception caught: ThresholdConfig::addTrigge rThreshold: threshold mapping exceeds limit

In a log file(s) just before this message is the following:

ThresholdConfig::addTriggerThreshold: threshold mapping 25 exceeds maximum for type 'JET' , abort!

All files are up to date in this MR, if someone can advice me? I changed Cabling.py so it reflects changes from 21.3 but with a style from master. Is there anything else connected?

Tagging also menu: @ckaldero @markowen and @aranzazu

All tests outputs are here: ~lidiaz/public/ATR-21850/

Without these changes I was crashing due to cabling not being up to date.

I'm afraid I'm out of my depth on this one, and I think Mark and Arantxa are away. Are @stelzer or @jmontejo able to take a quick look?

Hmmmm I thought @stelzer had removed the threshold limit at the time we introduced the new L1Calo items. This is anyway quite strange since I don't see that you are introducing new jet thresholds?

I think it's also tied up with !35317 (merged), where various L1 items were added and removed

Hi @jmontejo,

original change is here: !35317 (diffs) (different MR)

Lidija

Alright, we are timing out on this one again. If we don't have a fix in the next 30 minutes I will revert !35317 (merged).

Hi,

sorry, I have to remove now HLT chains that are seeded with L1 that were removed. It is now failing while running, but I will know in the next 30 minutes if this is the last one.

Together with @ckaldero we removed two L1 jet items as some temporary solution for the previous problem.

Lidija

Any news?

I am still chasing HLT items.

OK, then it's too late for the nightly. I just reverted your !35317 (merged). If you continue working on this MR make sure to merge it back into your development branch.

Stupid question, how do I do it? I have it written somewhere, but now I am too lost with the changes I have here.

resolved all threads

It seems now all is fine. Counts are different because some chains are commented out.

added 1 commit

• a7d215f1 - Hopefully final updates

Compare with previous version

added 94 commits

• a7d215f1...7e7fea0e - 85 commits from branch atlas:master
• 5994b0ce - ATR-21850 - fixing remaining bugs
• b7761539 - Updates
• 96636e27 - Fixing remaining items
• e2d16f78 - ATR-21850 and ATR-21624: Fixing remaining items
• 2b20ff43 - ATR-21850 and ATR-21624: Fixing remaining items
• 650835a6 - ATR-21850 and ATR-21624: Fixing remaining items
• 9dcbc98c - ATR-21850 and ATR-21624: Fixing remaining items
• 3eeb841a - Hopefully final updates
• acc89df8 - Merge branch 'TM_ATR-21850' of https://gitlab.cern.ch:8443/lidiaz/athena into TM_ATR-21850

Compare with previous version

Whatever I did with these commits is wrong. I will start ne MR soon.

closed

resolved all threads