Add new Detector flags for ITk

Adding dedicated detector flags for Upgrade detectors, to allow configurations more independently.

A few questions:

• Presumably we should forbid the ITk and ID to be on at the same time - is there are preferred way to do this? (see below - this will come later)

• At the moment, SimulateHGTD will set SimulateID to true. Presumably this should rather be SimulateITk in future, and is there a reason we only do this for the Simulate flags, not the Geometry ones? (HGTD now moved to SimulateITk)

cc @jchapman @asalzbur @goetz @sroe @cohm

We could use the GetDetDescrInfo(...) method and have some flag in the DDDB about the available detectors (as is done for CSC and the NSW detectors) or just to use the GeoModel.Run flag directly. My concern with both of these is that they mean that one can't rely on the flags being set to False by default. Maybe that's OK, but it removes some protections against accidental incorrect configurations. I think what we're really looking for is some kind of "sanity-checker" which runs before the flags are used. That doesn't exist yet AFAIK.

added 1 commit

• edaed667 - HGTD simulation flag now associated with ITk rather than ID

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 1 package:

• Control/AthenaConfiguration

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

CI Result FAILURE (hash edaed667)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18930]

added 458 commits

• edaed667...3f4ed5fa - 457 commits from branch atlas:master
• 48aacae9 - Add new Detector flags for ITk, to allow separate confgurations to be developed

Compare with previous version

This merge request affects 1 package:

• Control/AthenaConfiguration

Adding @ssnyder as watcher

resolved all threads

CI Result FAILURE (hash 48aacae9)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18983]

The failing tests seem to be:

• q431xAODDigestTest on the basis of (I think) a different number of jets being found.

copy master_q431_AOD_digest.ref
         run       event       nTopo   nIdTracks       nJets      nMuons
16c16
<       330470  1183751782         239         235           4           0
---
>       330470  1183751782         239         235           5           0
19c19
<       330470  1183754806         470         406          15           0
---
>       330470  1183754806         470         406          14           0
==================END q431 Digest Diff with exit code: 1 Wed Aug 19 16:41:29 CEST 2020
The xAODDigest diff failed!

I'm not sure how my changes could result in this, so is it possible this is a spurious difference/caused by changes elsewhere?

• Likewise, I see Trigger_athena_MC fails. Its less obvious to me there what exactly the problem is but maybe:

2020-08-19T160305 CEST TrigValSteering INFO     MessageCount Number of WARNING messages 1427 in log.RDOtoRDOTrigger is higher than threshold 0
2020-08-19T160305 CEST TrigValSteering INFO     MessageCount Number of INFO messages 1420 in log.RDOtoRDOTrigger is higher than threshold 20
2020-08-19T160305 CEST TrigValSteering INFO     MessageCount Number of other messages 63 in log.RDOtoRDOTrigger is higher than threshold 20

again, if anyone has any hints...

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaConfiguration

Adding @ssnyder as watcher

CI Result FAILURE (hash 48aacae9)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19062]

remaining testing issues should be fixed by !35766 (merged).

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaConfiguration

Adding @ssnyder as watcher

CI Result SUCCESS (hash 48aacae9)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19088]