AthContainers: Switch to using ThinningInfo for the lossy float compression inside copyAuxStoreThinned
This MR builds on !35444 (merged). With this MR we're switching to using ThinningInfo
to determine whether lossy float compression should be applied to a given AuxID
and apply it in copyAuxStoreThinned
. Parts that refer to the now-defunct IAuxStoreCompression
are completely removed. The next step is to completely get rid of this interface and its implementation in AuxContainerBase
.
One key item that was previously missing was a regression test that ensures the lossy float compression is applied correctly. copyAuxStoreThinned_test
is extended to address that problem. Since by default we don't yet compress anything, the changes should be transparent to existing workflows. However, I'm asking for full-unit-tests
to make sure there are no unintended side effects.
The next step will be cleaning up the previously implemented infrastructure as noted above.
Merge request reports
Activity
added full-unit-tests label
added Core master review-pending-level-1 labels
CI Result FAILURE (hash 89280c19)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18602] CI Result FAILURE (hash d16ac910)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18626]- Resolved by Alaettin Serhan Mete
- Resolved by Alaettin Serhan Mete
added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Alaettin Serhan Mete
Failure of unit-tests:
The following tests FAILED: 510 - MuonG4SD_CSCSensitiveDetector_gtest_ctest (Failed) [ERROR_MESSAGE] Errors while running CTest
added review-pending-level-1 label and removed review-user-action-required label
- Resolved by Alaettin Serhan Mete
It still isn't done - but found one type-o while looking over the code, and one possible suggestion. The type converting and
reinterpret-cast
is gnarly, but I don't know how to get around it!
added review-user-action-required label and removed review-pending-level-1 label
CI Result FAILURE (hash 3677d9fa)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18653]Looking at the last results, I see some additional tests (compared to the latest nightly) are failing w/:
-Py:PropertyProxy WARNING Found 4 duplicates among the 1067 genConfDb files : -Py:PropertyProxy WARNING -------------------------------------------------- -Py:PropertyProxy WARNING -<component name>: <module> - [ <duplicates> ] -Py:PropertyProxy WARNING -------------------------------------------------- -Py:PropertyProxy WARNING -HLTTest__TestHypoAlg: DecisionHandling.DecisionHandlingConf - ['TrigUpgradeTest.TrigUpgradeTestConf'] -Py:PropertyProxy WARNING -HLTTest__TestHypoTool: DecisionHandling.DecisionHandlingConf - ['TrigUpgradeTest.TrigUpgradeTestConf'] -Py:PropertyProxy WARNING -HLTTest__TestInputMaker: DecisionHandling.DecisionHandlingConf - ['TrigUpgradeTest.TrigUpgradeTestConf'] -Py:PropertyProxy WARNING -HLTTest__TestRecoAlg: DecisionHandling.DecisionHandlingConf - ['TrigUpgradeTest.TrigUpgradeTestConf'] -Py:PropertyProxy WARNING Fix your cmt/requirements file !!
which is probably an incremental build issue. The only fishy one is
TileTPCnv_TileDigitsCnv_p2_test_ctest
which segfaults. I ran all the tests inTileTPCnv
locally w/ my changes and all succeeds so I'm pretty sure that's not related to my changes either.I'll be partially offline next week. So, it would be great to get this done before that if possible. Please let me know if there are any concrete suggestions. Thanks.
- Resolved by Alaettin Serhan Mete