Add new algorithms to create charged and neutral FlowElements

Three new algorithms are added to create FlowElements, which can be enabled via a new python flag. Eventually FlowElement will replace the current PFO. Relevant to ATLJETMET-1262

This merge request affects 4 packages:

• Event/xAOD/xAODPFlow
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
• Reconstruction/PFlow/PFlowValidation/PFODQA
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

added Analysis EDM JetEtmiss Reconstruction master review-pending-level-1 labels

added 1 commit

• b8902fe0 - Make physics validation of FlowElements depend on new python flag in eflowRec.

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODPFlow
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
• Reconstruction/PFlow/PFlowValidation/PFODQA
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

CI Result FAILURE (hash 66566e37)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18723]

CI Result FAILURE (hash b8902fe0)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18727]

Compilation warnings seem related

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx: In constructor 'PFChargedFlowElementValidationPlots::PFChargedFlowElementValidationPlots(PlotBase*, std::__cxx11::string, std::__cxx11::string)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx:7:124: warning: unused parameter 'sFlowElementContainerName' [-Wunused-parameter]
 PFChargedFlowElementValidationPlots::PFChargedFlowElementValidationPlots(PlotBase* pParent, std::string sDir,  std::string sFlowElementContainerName) : PlotBase(pParent, sDir)
                                                                                                                ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx: In member function 'void PFChargedFlowElementValidationPlots::fill(const FlowElement&, const Vertex*)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx:11:73: warning: unused parameter 'theFE' [-Wunused-parameter]
 void PFChargedFlowElementValidationPlots::fill(const xAOD::FlowElement& theFE, const xAOD::Vertex* theVertex ){
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx:11:100: warning: unused parameter 'theVertex' [-Wunused-parameter]
 void PFChargedFlowElementValidationPlots::fill(const xAOD::FlowElement& theFE, const xAOD::Vertex* theVertex ){

Jenkins please retry a build

This merge request affects 4 packages:

• Event/xAOD/xAODPFlow
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
• Reconstruction/PFlow/PFlowValidation/PFODQA
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

CI Result SUCCESS (hash b8902fe0)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18760]

Hello, there're still 3 related warnings, would you please resolve it?

http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G8AthenaOpt/NICOS_Log_MR-35611-2020-08-15-05-03/Reconstruction_PFlow_PFlowValidation_PFODQA.html

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PFChargedFlowElementValidationPlots.cxx:7:124: warning: unused parameter 'sFlowElementContainerName' [-Wunused-parameter]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 50dead6d - Revert "A first version of validation code for pflow FlowElements (charged)."

Compare with previous version

This merge request affects 3 packages:

• Event/xAOD/xAODPFlow
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• 60aa5a5a - Remove flow element validaiton config code in preparation to remove prototype...

Compare with previous version

CI Result SUCCESS (hash 50dead6d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18857]