Skip to content
Snippets Groups Projects

Added IsolationBuilder algorithm to Electron Chains

Merged Added IsolationBuilder algorithm to Electron Chains
fernando/athena:TrigElectronIso into master
All threads resolved!
Merged Fernando Monticelli requested to merge fernando/athena:TrigElectronIso into master
All threads resolved!

This is to add isolationBuilder to trigger electron sequence so we can have isolated chains as discussed in ATR-20756.

Tagging @dbakshig and @cjmeyer

Changing also the EventViews of precision electron from PrecisionTracking to PrecisionElectron too

Fernando

Merge request reports

Pipeline #1873544 passed

Stage: external

    Pipeline passed for 3f5d2f12 on fernando:TrigElectronIso

    Approval is optional

    Merged by Edward MoyseEdward Moyse 4 years ago (Aug 21, 2020 7:39am UTC)

    Merge details

    • Changes merged into master with 705c3f44 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Fernando Monticelli added Egamma Trigger master labels

      added Egamma Trigger master labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 2 packages:

      • Trigger/TrigHypothesis/TrigEgammaHypo
      • Trigger/TriggerCommon/TriggerMenuMT

      Adding @bernius as watcher

    • ATLAS Robot added TriggerMenu review-pending-level-1 labels

      added TriggerMenu review-pending-level-1 labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :negative_squared_cross_mark: CI Result FAILURE (hash 7a0753d7)

      Athena AthSimulation AthGeneration AnalysisBase
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :warning: Athena: number of compilation errors 0, warnings 1
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18783]

    • Johannes Junggeburth
      Johannes Junggeburth @jojungge ·
      Developer

      Please resolve

      # CMake ---> /build2/ci-builds/master/Athena/build/Athena/CMakeFiles/atlas_build_run.sh flake8_atlas --select ATL,F,E101,E7,E9,W6 --ignore ATL238,ATL9,E701,E702,E704,E741 --enable-extensions ATL902 -- /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetFlavourTaggingConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetTrackingConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/GenerateBjetChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bphysics/BphysicsDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bphysics/BphysicsSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bphysics/GenerateBphysicsChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bphysics/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/BeamspotChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/CosmicChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/GenerateBeamspotChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/GenerateCosmicChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/GenerateMonitorChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/GenerateStreamingChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/MonitorChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/StreamingChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CalibCosmicMon/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Combined/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CommonSequences/CaloSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CommonSequences/EventBuildingSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/CommonSequences/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/EgammaDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/GenerateElectronChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/GeneratePhotonChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/PhotonDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/PhotonSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/PrecisionCaloRec.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/PrecisionCaloSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/PrecisionElectronSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/TrigEgammaFactories.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/ElectronRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionElectronRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/generateElectron.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/HeavyIon/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/GenerateJetChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetMenuSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetTrackingConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/TriggerJetMods.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/generateJet.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/AlgConfigs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/ConfigHelpers.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/GenerateMETChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/METChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/METMenuSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/METRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MET/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/CFValidation.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/CPS.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/ChainConfigurationBase.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/ChainDefInMenu.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/ChainDictTools.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/ChainMerging.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/Cosmic_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/Dev_HI_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/DictFromChainName.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/EventBuildingInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/GenerateMenuMT.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/GenerateMenuMT_newJO.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/GroupInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/HLTCFConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/HLTCFConfig_newJO.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/HLTCFDot.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/HLTMenuJSON.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_emu_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1_newJO.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MC_pp_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MenuAlignmentTools.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MenuComponents.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MenuComponentsNaming.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MenuPrescaleConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/MenuUtil.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/PhysicsP1_HI_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/PhysicsP1_pp_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/Physics_pp_run3_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/SignatureDicts.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/StreamInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/TriggerConfigHLT.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MinBias/GenerateMinBiasChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MinBias/MinBiasChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MinBias/MinBiasMenuSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MinBias/MinBiasRecoSequence.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/MinBias/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/GenerateMuonChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/MuonDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/MuonSequenceSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/MuonSetup.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Muon/generateMuon.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Photon/PhotonRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Photon/TrigPhotonFactories.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Photon/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Photon/generatePhoton.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Tau/GenerateTauChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Tau/TauChainConfiguration.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Tau/TauMenuSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Tau/TauRecoSequences.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Tau/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Test/GenerateTestChainDefs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Test/TestDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Test/ViewCFTest.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Test/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Boards.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/BunchGroupSet.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/CTP.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/CTPCondition.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Connectors.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Items.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/L1Menu.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/L1Menu2JSON.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/L1MenuFlags.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Limits.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Logic.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/MenuConfObj.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/MenuUtils.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/MonCounters.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/PrescaleHelper.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/ThresholdType.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/Thresholds.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/TopoAlgorithms.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/TopoAlgos.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/CTPInputConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/MonitorDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ThresholdDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ThresholdDefLegacy.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDefLegacy.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDefMuctpi.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDefMultiplicity.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TriggerTypeDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TypeWideThresholdConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/L1MenuConfig.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/MenuMapping.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/Menu_MC_pp_v8.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/Menu_MC_pp_v8_inputs.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/Menu_MC_pp_v8_inputs_legacy.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1Topo/L1TopoFlags.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1Topo/L1TopoMenu.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1Topo/TopoAlgos.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1Topo/TopoOutput.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1Topo/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1TopoMenu/Menu_LS2_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1TopoMenu/TopoAlgoDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/L1TopoMenu/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/BunchGroupSet.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/CTPInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Cabling.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/CaloInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Limits.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Logic.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1Condition.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1Flags.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1Menu.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1MenuItems.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1MenuUtil.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1MonCounters.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/Lvl1Thresholds.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/MuctpiInfo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/PrescaleHelper.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/TriggerTypeDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/XMLMenuReader.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/XMLReader.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/CaloDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/ItemDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/ItemDefRun1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/L1Seeds.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/Menu_L1_alfa_v2.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/Menu_LS2_v1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/MonitorDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/ThresholdDef.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/LVL1Menu/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/TriggerConfigL1Topo.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/TriggerConfigLVL1.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/LVL1MenuConfig/__init__.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/__init__.py
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/TrigEgammaFactories.py:22:1: warning: F401 'egammaRec.Factories.getPropertyValue' imported but unused
from egammaRec.Factories import ToolFactory, AlgFactory, getPropertyValue
^

      Tests failed due to timeout

    • Johannes Junggeburth added review-user-action-required label and removed review-pending-level-1 label

      added review-user-action-required label and removed review-pending-level-1 label

    • Fernando Monticelli added 1 commit

      added 1 commit

      • 3f5d2f12 - removed egammaRec.Factories.getPropertyValue as unused

      Compare with previous version

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 2 packages:

      • Trigger/TrigHypothesis/TrigEgammaHypo
      • Trigger/TriggerCommon/TriggerMenuMT

      Adding @bernius as watcher

    • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

      added review-pending-level-1 label and removed review-user-action-required label

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :negative_squared_cross_mark: CI Result FAILURE (hash 3f5d2f12)

      Athena AthSimulation AthGeneration AnalysisBase
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18865]

    • Fernando Monticelli
      Fernando Monticelli @fernando ·
      Author Developer

      I see a timeout in TriggerMenuMT_full_menu_cf_ctest. I'll check if is due trackIsolationTool or what...

    • Fernando Monticelli
      Fernando Monticelli @fernando ·
      Author Developer

      OK, Locally test pass :-( Should we retry a build?

    • Fernando Monticelli mentioned in merge request !35482 (closed)

      mentioned in merge request !35482 (closed)

    • Fernando Monticelli
      Fernando Monticelli @fernando ·
      Author Developer

      please Jenkins retry a build

    • Ana Maria Rodriguez Vera
      Ana Maria Rodriguez Vera @anmrodri ·
      Developer

      Jenkins please retry build

    • Ana Maria Rodriguez Vera
      Ana Maria Rodriguez Vera @anmrodri ·
      Developer

      For some reason Jenkins did not catch on the retry, but the same timeout is seen in the nightly, so it might be unnecessary. Can L2 check?

    • Ana Maria Rodriguez Vera added review-pending-level-2 label and removed review-pending-level-1 label

      added review-pending-level-2 label and removed review-pending-level-1 label

    • Fernando Monticelli
      Fernando Monticelli @fernando ·
      Author Developer

      I see this has been discussed here: https://its.cern.ch/jira/browse/ATEAM-639?focusedCommentId=3422469&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-3422469

      So maybe we need to try to merge to master after that patch?

    • Johannes Junggeburth
      Johannes Junggeburth @jojungge ·
      Developer

      The CI is currently broken. If the CI is fixed can you please pull from the master @fernando?

    • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigHypothesis/TrigEgammaHypo
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @bernius as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label

    added review-pending-level-1 label and removed review-pending-level-2 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 3f5d2f12)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19059]

  • M
    Mike Hance @mhance ·
    Developer

    Looks like failures might be fixed by !35766 (merged), will retry.

  • M
    Mike Hance @mhance ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigHypothesis/TrigEgammaHypo
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @bernius as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 3f5d2f12)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19087]

  • M
    Mike Hance @mhance ·
    Developer

    Code changes look good, and all tests passed. L1 approving.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit 705c3f44

    mentioned in commit 705c3f44

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Fernando Monticelli mentioned in merge request !34776 (closed)

    mentioned in merge request !34776 (closed)

  • Mark Sutton
  • Mark Sutton
    Mark Sutton @sutt ·
    Developer

    Hi, is there somewhere in this request where we are configuring the isolation to be about the electron vertex rather than about any event vertex ? Only I could not find it.

    We absolutely, must use the electron z-vertex for any track based isolation, even if the offline is (incorrectly in my view) using an event vertex based isolation. If one uses standard vertex isolation, this would of course only be in any way relevant, if the event vertex and the electron z-vertices were consistent, so it is simpler and more robust to simply use only the electron z-vertex from the outset.

    The only exception to this might be for forward electrons with no track - but of course track based isolation would mostly not be possible anyhow if the electron was too far forward for the tracking.

    Cheers, Mark

  • Fernando Monticelli
    Fernando Monticelli @fernando ·
    Author Developer

    I havn't found it. So we are not passing any vertex so need to check what the tool does in that case. If needed we will introduce a flag to use electron's vertex. Or use vertex of higher pt track in RoI as we did in Run2.

    Cheers! Fer

  • Edward Moyse resolved all threads

    resolved all threads

  • Johannes Junggeburth mentioned in merge request !36260 (merged)

    mentioned in merge request !36260 (merged)

    • Please register or sign in to reply