Skip to content
Snippets Groups Projects

Beam spot reweighting

Merged Michael Duehrssen-Debling requested to merge mduehrss/athena:BeamSpotReweighting into master
All threads resolved!

Add information for beam spot size reweighting to xAOD::EventInfo and an algorithm that calculates the beam spot size reweighting weight in z

Edited by Michael Duehrssen-Debling

Merge request reports

Pipeline #1877699 failed

Pipeline failed for 5838a806 on mduehrss:BeamSpotReweighting

Approval is optional

Merged by Edward MoyseEdward Moyse 4 years ago (Aug 21, 2020 9:11am UTC)

Merge details

  • Changes merged into master with 959b416d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • 0132580f - add method to check if a beam spot reweighting weight is present
    • 7c6f088d - make all information output in the event loop DEBUG

    Compare with previous version

  • added 1 commit

    • e2ed1d10 - remove isClonable() from BeamSpotReweightingAlg

    Compare with previous version

  • resolved all threads

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Event/xAOD/xAODEventInfo
    • Simulation/BeamEffects

    Adding @jchapman ,@vpascuzz ,@akraszna as watchers

  • added EDM master labels

  • :white_check_mark: CI Result SUCCESS (hash e2ed1d10)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18931]

  • Tadej Novak
  • Michael Duehrssen-Debling unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 1 commit

    • 5838a806 - Make calculation of Gauss ratio for the weight more robust

    Compare with previous version

  • This merge request affects 2 packages:

    • Event/xAOD/xAODEventInfo
    • Simulation/BeamEffects

    Adding @jchapman ,@vpascuzz ,@akraszna as watchers

  • resolved all threads

  • :negative_squared_cross_mark: CI Result FAILURE (hash 5838a806)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18997]

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Event/xAOD/xAODEventInfo
    • Simulation/BeamEffects

    Adding @jchapman ,@vpascuzz ,@akraszna as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 5838a806)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19066]

  • MC trigger failures should be resolved by !35766 (merged).

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Event/xAOD/xAODEventInfo
    • Simulation/BeamEffects

    Adding @jchapman ,@vpascuzz ,@akraszna as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 5838a806)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19095]

  • The failing trigger test is unrelated, this new algorithm is so far not even scheduled (and CI actually succeeded the first trial)

  • merged

  • Edward Moyse mentioned in commit 959b416d

    mentioned in commit 959b416d

  • Please register or sign in to reply
    Loading