Skip to content
Snippets Groups Projects

Magnetic Field Elements : test and tidy up

Merged Magnetic Field Elements : test and tidy up
ATLAS-EGamma/athena:MagneticField_elem_test_vec into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:MagneticField_elem_test_vec into master

Magnetic Field Elements :

  • small test aesthetic fixes
  • add reference for the test,
  • move more methods from .h to .icc or .cxx

Mentioning @schaffer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth removed review-approved label

    removed review-approved label

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Developer

    Sorry my approval came to before, I finished my first coffee. There's a compilation error that has to be fixed

    # CMake ---> /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DATLAS_GAUDI_V21 -DCLHEP_ABS_DEFINED -DCLHEP_MAX_MIN_DEFINED -DCLHEP_SQR_DEFINED -DGAUDI_V20_COMPAT -DHAVE_64_BITS -DHAVE_GAUDI_PLUGINSVC -DMagFieldElements_EXPORTS -DPACKAGE_VERSION="MagFieldElements-00-00-00" -DPACKAGE_VERSION_UQ=MagFieldElements-00-00-00 -D__IDENTIFIER_64BIT__ -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/MagneticField/MagFieldElements -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tools/PathResolver -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaBaseComps -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/DataModelRoot -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinks -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/SGTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/StoreGate -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthAllocators -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/PersistentDataModel -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/ROOT/v6.20.06/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/Boost/1.72.0/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/eigen/3.3.7/x86_64-centos7-gcc8-opt/include/eigen3 -isystem /build2/ci-builds/master/Athena/install/GAUDI/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/tbb/2020_U1/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/Python/3.7.6/x86_64-centos7-gcc8-opt/include/python3.7m -isystem /cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/include/python3.7m -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/CORAL/3_2_4/x86_64-centos7-gcc8-opt/include -fplugin=/build2/ci-builds/master/Athena/install/AthenaExternals/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/lib/libchecker_gccplugins.so -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -o CMakeFiles/MagFieldElements.dir/src/BFieldCache.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/MagneticField/MagFieldElements/src/BFieldCache.cxx
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/MagneticField/MagFieldElements/src/BFieldCache.cxx:5:10: fatal error: MagFieldElement/BFieldCache.h: No such file or directory
 #include "MagFieldElement/BFieldCache.h"
  • Johannes Junggeburth added review-user-action-required label

    added review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 330461b3)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19112]

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Author Developer

    yes they were 2 commits as you see

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Author Developer

    Jenkins please retry a build

  • Christos Anastopoulos added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MagneticField/MagFieldElements
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 330461b3)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19157]

  • M
    Mike Hance @mhance ·
    Developer

    Changes seem straightforward, and tests pass. L1 approving.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply