Skip to content
Snippets Groups Projects

Initial testing of ISF main config

Merged Initial testing of ISF main config
rtombs/athena:ISFtest into master
All threads resolved!
Merged Rupert Tombs requested to merge rtombs/athena:ISFtest into master
All threads resolved!

Add ISF_MainConfigNew_Test.py (ripped from @dnoel /ISF_newstyle) to test new style ISF configuration.

Make various fixes such that it configures without error. The configured accumulator is not yet able to run without error, however, and does not match old-style config.

Fixes to accumulator merging, tool attachment and symbol naming.

Move some G4 config to G4AtlasUserActionConfigNew.py to avoid circular dependence.

Add CaloG4SimConfigNew.py.

Edited by Rupert Tombs

Merge request reports

Pipeline #1884677 passed

Stage: external

Pipeline passed for 20336abf on rtombs:ISFtest

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Aug 24, 2020 2:13pm UTC)

Merge details

  • Changes merged into master with 0671bab8.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rupert Tombs resolved all threads

    resolved all threads

  • Rupert Tombs added 1 commit

    added 1 commit

    • d5610572 - Initial ISF python testing and fixes to make it run

    Compare with previous version

  • Rupert Tombs resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ad4e1d9d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :warning: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 3
    :warning: AthSimulation: number of compilation errors 0, warnings 3
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19144]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 10 packages:

    • Calorimeter/CaloG4Sim
    • Simulation/G4Atlas/G4AtlasServices
    • Simulation/G4Utilities/G4UserActions
    • Simulation/ISF/ISF_Config
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_Core/ISF_Tools
    • Simulation/ISF/ISF_Fatras/ISF_FatrasServices
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Services
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
    • Simulation/ISF/ISF_SimulationSelectors

    Adding @jchapman ,@pavol ,@vpascuzz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash d5610572)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :warning: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 3
    :warning: AthSimulation: number of compilation errors 0, warnings 3
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19180]

  • Rupert Tombs added 1 commit

    added 1 commit

    • f12781bc - Initial ISF python testing and fixes to make it run

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 10 packages:

    • Calorimeter/CaloG4Sim
    • Simulation/G4Atlas/G4AtlasServices
    • Simulation/G4Utilities/G4UserActions
    • Simulation/ISF/ISF_Config
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_Core/ISF_Tools
    • Simulation/ISF/ISF_Fatras/ISF_FatrasServices
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Services
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
    • Simulation/ISF/ISF_SimulationSelectors

    Adding @jchapman ,@pavol ,@vpascuzz as watchers

  • Rupert Tombs added 1 commit

    added 1 commit

    • 20336abf - Initial ISF python testing and fixes to make it run

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 10 packages:

    • Calorimeter/CaloG4Sim
    • Simulation/G4Atlas/G4AtlasServices
    • Simulation/G4Utilities/G4UserActions
    • Simulation/ISF/ISF_Config
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_Core/ISF_Tools
    • Simulation/ISF/ISF_Fatras/ISF_FatrasServices
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Services
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
    • Simulation/ISF/ISF_SimulationSelectors

    Adding @jchapman ,@pavol ,@vpascuzz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 20336abf)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19194]

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer
      Resolved by Rupert Tombs

      :negative_squared_cross_mark: CI Result FAILURE (hash f12781bc)

      Athena AthSimulation AthGeneration AnalysisBase
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :warning: :warning: :white_check_mark: :white_check_mark:
      required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :warning: Athena: number of compilation errors 0, warnings 1
      :warning: AthSimulation: number of compilation errors 0, warnings 1
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19193]

  • Rupert Tombs resolved all threads

    resolved all threads

  • Magdalena Slawinska added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

    • M
      Magdalena Slawinska @maslawin ·
      Developer
      Resolved by Rupert Tombs

      Hi, please fix failed test and resolve the compilation warning:

      /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/python/ISF_SimulationSelectorsConfigNew.py:22:1: warning: F401 'ISF_FatrasServices.ISF_FatrasConfig.fatrasSimServiceIDCfg' imported but unused from ISF_FatrasServices.ISF_FatrasConfig import ( ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/python/ISF_SimulationSelectorsConfigNew.py:173:11: warning: F821 undefined name 'FatrasSimServiceIDCfg' acc = FatrasSimServiceIDCfg(flags) ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/python/ISF_SimulationSelectorsConfigNew.py:433:11: warning: F821 undefined name 'FatrasSimServiceIDCfg' acc = FatrasSimServiceIDCfg(flags) ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/python/ISF_SimulationSelectorsConfigNew.py:502:11: warning: F821 undefined name 'FatrasSimServiceIDCfg' acc = FatrasSimServiceIDCfg(flags)

            ^

      /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/python/ISF_SimulationSelectorsConfigNew.py:640:11: warning: F821 undefined name 'FatrasSimServiceIDCfg' acc = FatrasSimServiceIDCfg(flags)

      (looks like a typo: fatrasSimServiceIDCfg-> FatrasSimServiceIDCfg)

      Magdalena (L1)

      Edited by Magdalena Slawinska
  • Rupert Tombs added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Rupert Tombs resolved all threads

    resolved all threads

  • M
    Mike Hance @mhance ·
    Developer

    Thanks @rtombs, approving now.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit 0671bab8

    mentioned in commit 0671bab8

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply