Skip to content
Snippets Groups Projects

[ATR-21910][ATR-21910] Trig Cost online concurrency fixes

Merged [ATR-21910][ATR-21910] Trig Cost online concurrency fixes
All threads resolved!
Merged Tim Martin requested to merge tamartin/athena:trigCostConcurrency into master
All threads resolved!

Resolve two issues seen at P1 in MT mode.

  1. Multiple slots could access the thread-hash -> thread-counter map concurrently. The mutex protection was only per-slot. Resolved by adding a small global lock to this map lookup.
  2. We encountered hash collisions online. As we only collect monitoring data here, this is not too critical and the exception can be caught and discarded with only a DEBUG message. A unit test was added around this.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 2 packages:

    • Trigger/TrigConfiguration/TrigConfHLTUtils
    • Trigger/TrigMonitoring/TrigCostMonitorMT

    Adding @mark ,@orlando ,@cmorenom ,@asonay as watchers

  • Tim Martin resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash b162399f)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19151]

  • Tests pass, and changes look reasonable. L1 approving.

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit de3375e3

  • Please register or sign in to reply
    Loading