Fix cluster moments computation
It was found, that differences in cluster moments, seen between rel. 21 and rel. 22, are coming from change in Eigen computation of vector eigenvalues, where rel. 22 version have small non-zero values for the same input as in rel. 21 where values were exactly zero. This MR is changing a test == 0.0 to < epsilon.
MR will of course fail the Tier0 tests, but that's expected and should bring results back to values in rel. 21.
Merge request reports
Activity
added frozen-tier0-violating label
added Calorimeter JetEtmiss master review-pending-level-1 labels
CI Result SUCCESS (hash f2c041d8)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19172]added review-approved label and removed review-pending-level-1 label
@pavol we don't see the comparison failure. Is this ok? Do you need to update any logs to prevent the nightly tests failing?
Hi @abarton,
no I do not expect the comparison failure in standard tests, only if one run frozen T0 policy tests (RunTier0Tests.py), but those are not part of testing in master, right ?
Best, Pavol
mentioned in commit 35bced4b
added sweep:ignore label