New eflowRec algorithm to link Flow Elements to Electrons/Photons

Dear experts/Athena enthusiasts (cc @mhodgkin)

I'm adding an algorithm in Reconstruction/eflowRec to associate the Flow Elements (successor to PFO objects/ Particle Flow objects) to electrons and converted photons.

Thanks

Matt.

added EDM Reconstruction master labels

changed the description

changed title from WIP: New eflowRec algorithm to Link Flow Elements to Electrons/Photons to WIP: New eflowRec algorithm to link Flow Elements to Electrons/Photons

added 2 commits

• 64abf2b9 - add renamed algo instead of the dummy name
• 1fa677cf - PFEGamFlowElementAssoc: rename the Association alg to something more sensible

Compare with previous version

Have now changed the algorithm name from the dummy algorithm name to one that should be more clear.

unmarked as a Work In Progress

changed the description

This merge request affects 2 packages:

• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

added JetEtmiss review-pending-level-1 labels

Jenkins please retry build

Hi Matthew, I think the build job is still running.

CI Result FAILURE (hash 1fa677cf)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19321]

Having a look at the log for CI, I see the following:

In file included from /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.h:940:
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:79:11: error: cannot initialize a variable of type 'B_nc *' (aka 'DataVector<xAOD::IParticle> *') with an rvalue of type 'T_nc *' (aka 'DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> *')
    B_nc* b = reinterpret_cast<T_nc*> (p);
          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:62:21: note: in instantiation of function template specialization 'SG::BaseInfoImpl<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::converter<DataVector<xAOD::IParticle> >' requested here
                    converter<B>, converterTo<B>, is_virtual);
                    ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:141:16: note: in instantiation of function template specialization 'SG::BaseInfoImpl<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::add_base<DataVector<xAOD::IParticle> >' requested here
    c.template add_base<B>(is_virtual);
               ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:144:46: note: in instantiation of function template specialization 'SG::BaseInfo_init<DataVector<xAOD::IParticle> >::init<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >' requested here
    BaseInfo_init<typename Bases<B>::Base1>::init (c, is_virtual);
                                             ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:195:21: note: in instantiation of function template specialization 'SG::BaseInfo_init<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::init<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >' requested here
  BaseInfo_init<T>::init (*this, false);
                    ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:437:30: note: in instantiation of member function 'SG::BaseInfoImpl<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::BaseInfoImpl' requested here
BaseInfoImpl<T> BaseInfo<T>::s_instance;
                             ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:432:3: note: in instantiation of static data member 'SG::BaseInfo<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::s_instance' requested here
  s_instance.maybeInit();
  ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:414:10: note: in instantiation of member function 'SG::BaseInfo<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::instance' requested here
  return instance();
         ^
/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthenaKernel/BaseInfo.icc:463:59: note: in instantiation of member function 'SG::BaseInfo<DataVector<xAOD::Jet_v1, DataModel_detail::NoBase> >::baseinfo' requested here
                        [] (BaseInfoBase*) { BaseInfo<T>::baseinfo(); });
                                                          ^
TInterpreter::AutoParse   ERROR   Error parsing payload code for class xAOD::JetAuxContainer_v1 with content:

#line 1 "libxAODJetDict dictionary payload"

This was not related to my code changes in any way. I think this might be resolved with a merge from upstream/master.

added 3426 commits

• 1fa677cf...8d5b3639 - 3424 commits from branch atlas:master
• 8e58096f - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into...
• 22bd707e - Pulled changes from upstream to allow PFEgamFlowElement Algs to pass jenkins tests

Compare with previous version

This merge request affects 2 packages:

• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

CI Result FAILURE (hash 22bd707e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19345]

added 1 commit

• 54b3d68c - fix q431 error in xAODPflow dictionary

Compare with previous version

This merge request affects 2 packages:

• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

Jenkins please retry build

CI Result FAILURE (hash 54b3d68c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19390]

• adds new eflow algorithm
• changes xAOD data model (dummy1, 3, 4??)
• The CI seems to be failing with "StreamESD FATAL commitOutput failed."
• I do not think they are related but didn't see the failures happening in the nightly (or I looked in the wrong place/merge isn't quite up to date, etc.).

Passing to L2 for verification.

added review-pending-level-2 label and removed review-pending-level-1 label

I can reproduce the test failures locally and a fix works for the StreamESD issue. But then the xAODDigest.py step fails on retrieving the jet container (which is puzzling because Matt has not changed any jet code). Changing to WIP because I think it may take some time to understand and fix the problem.

Cheers,

Mark

marked as a Work In Progress

Removing review label since this was changed to WIP. (L2)

removed review-pending-level-2 label

added 2 commits

• 905db8b0 - trying to fix this q431 by tweaking configs
• 275f0580 - temp commit with more tweaks

Compare with previous version

mentioned in merge request !36273 (merged)

added 1 commit

• 0efc7863 - Add EDM/Datavector instantiation tweaks to see if this does the trick to fix the Q431 error

Compare with previous version

Jenkins please retry a build

This merge request affects 3 packages:

• Event/xAOD/xAODJet
• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

CI Result FAILURE (hash 0efc7863)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 12, warnings 22
AthSimulation: number of compilation errors 5, warnings 0
AthGeneration: number of compilation errors 17, warnings 2
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20200]

Jenkins please retry a build

Can you resolve conflicts and we re-try the CI with 6.22 (prb will have the same issue)

added 1138 commits

• 0efc7863...49d89465 - 1136 commits from branch atlas:master
• b5293517 - Merging Christos' changes to the EDM
• a4ec7ffe - merge in patch to EDM, and remove duplicate use of the DATAVECTOR_BASE macro...

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers

CI Result FAILURE (hash a4ec7ffe)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20400]

Jenkins please retry a build

This merge request affects 2 packages:

• Event/xAOD/xAODPFlow
• Reconstruction/eflowRec

Adding @goetz ,@akraszna ,@mhodgkin as watchers