Skip to content
Snippets Groups Projects

Making TAUP1 functional

Merged Making TAUP1 functional
martindl/athena:DFTau_R22_25Aug20 into master
All threads resolved!
Merged Bertrand Martin Dit Latour requested to merge martindl/athena:DFTau_R22_25Aug20 into master
All threads resolved!

Hello,

This MR is making minimal changes and cleanup to TAUP1 to make it functional in R22. To be used as a baseline for future developments.

Cheers, Bertrand

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • M
    Mike Hance @mhance ·
    Developer

    Hi Bertrand, the changes mostly look fine, just wondering about the removal of the electron info, and whether we can do that more gracefully than by commenting. Thanks! Mike (L1 shifter)

  • Bertrand Martin Dit Latour added 1 commit

    added 1 commit

    • eacd7f41 - comment out electron part until it's functional

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
  • Bertrand Martin Dit Latour resolved all threads

    resolved all threads

  • Bertrand Martin Dit Latour
    Bertrand Martin Dit Latour @martindl ·
    Author Developer

    Thanks for the suggestion. I've commented out the electron part of the skimming until the issue is solved.

  • M
    Mike Hance @mhance ·
    Developer

    Thanks Bertrand, once the new CI job is done I'll approve!

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash eacd7f41)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19335]

  • M
    Mike Hance @mhance ·
    Developer

    Tests pass, code looks good, L1 approving.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit ffc6e1ae

    mentioned in commit ffc6e1ae

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply