Eliminate use of L1/HLT ConfigSvc XML infromation in L1 decoder

Removes usage of information provided via legacy menu XML files from the L1 decoder. For that needed to make the LVL1 and HLT services to be "force" created. FI @smh Tagging @stelzer @mark
Also, printout in CA was expanded to show is a service will be created even if no clients request it.

This merge request affects 3 packages:

• Control/AthenaConfiguration
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TrigSteer/L1Decoder

Adding @tamartin ,@asonay ,@orlando ,@ssnyder ,@cmorenom ,@mark as watchers

added Core Trigger master review-pending-level-1 labels

Hi @tbold,

just to make sure: the L1ConfigSvc is still being called right? It is still needed by L1.

Cheers, Joerg

Hi @tbold

Trying to understand the create=True. I guess this is to CA-ify this line https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Trigger/TrigConfiguration/TrigConfigSvc/python/TrigConfigSvcCfg.py#0150

But not sure why this is needed / what this actually does?

CI Result FAILURE (hash 6c4f157c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19662]

I suppose we should wait for !36051 (merged) which might impact the CI failure.

Jenkins please retry a build

This merge request affects 3 packages:

• Control/AthenaConfiguration
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TrigSteer/L1Decoder

Adding @tamartin ,@asonay ,@orlando ,@ssnyder ,@cmorenom ,@mark as watchers

CI Result SUCCESS (hash 6c4f157c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19685]

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

The migration from XML to JSON for the CTPUnpacker is tracked in ATR-21864. Ideally I would have liked to keep the flexibility to use XML or JSON in the CTPUnpacker a bit longer. To follow the order that is lined out in ATR-21862.

resolved all threads

added review-pending-level-1 label and removed review-user-action-required label

I am going to rerun the CI since the last time it was run is 2 weeks ago and the logs are no longer available to inspect the failed optional tests.

L1 Reviewer

Jenkins please retry a build

Flagging again as user-action-requires as this cannot be merged due to conflict:

CONFLICT (content): Merge conflict in Trigger/TrigSteer/L1Decoder/src/CTPUnpackingTool.h

added review-user-action-required label and removed review-pending-level-1 label

added 1639 commits

• 6c4f157c...77b5562e - 1637 commits from branch atlas:master
• 094325b2 - resoling conflict that is not realy a conflict
• 7baa1d32 - Merge remote-tracking branch 'upstream/master' into l1decoder-no-confsvc

Compare with previous version

This merge request affects 3 packages:

• Control/AthenaConfiguration
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TrigSteer/L1Decoder

Adding @tamartin ,@asonay ,@orlando ,@ssnyder ,@cmorenom ,@mark as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 7baa1d32)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20956]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d0b617fa

added sweep:ignore label

mentioned in merge request !36863 (merged)