Private tool fix/muon segment combiners

Simple fix of private tools. The first commit is just style fixes. The second one contains all important changes.

It does not pass all tests. I think, it is necessary to modify some configuration.

WARNING: big files (>100K) are found in the changeset

128K in file MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MuonCurvedSegmentCombiner/src/MuonCurvedSegmentCombiner.cxx

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MooSegmentCombinationFinder
• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MuonCurvedSegmentCombiner

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result FAILURE (hash 5ca15c6f)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19830]

Some unit tests failed. Please take a look. Cheers, L1

added review-user-action-required label and removed review-pending-level-1 label

added 502 commits

• 5ca15c6f...e739c48f - 500 commits from branch atlas:master
• 53319019 - Merge branch 'master' of https://gitlab.cern.ch/atlas/athena into...
• f0ffed19 - Fix Tests

Compare with previous version

WARNING: big files (>100K) are found in the changeset

128K in file MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MuonCurvedSegmentCombiner/src/MuonCurvedSegmentCombiner.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MooSegmentCombinationFinder
• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MuonCurvedSegmentCombiner
• Trigger/TrigAlgorithms/TrigMuonEF

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added Trigger review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash f0ffed19)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20121]

Hi @mpenzin, can you remove the style changes or put them in a separate MR to be discussed if we want to include them? Although it is true the code style is not always the best, you are currently unnecessarily rewriting the history.

Tadej (L2)

added review-user-action-required label and removed review-pending-level-1 label

Hi, please see my comment on !36049 (merged)

Looks OK from the functionality point of view.

Tadej (L2)

added RC Attention Required review-approved labels and removed review-user-action-required label

merged

mentioned in commit 6effd81e

added sweep:ignore label