Moving Prescale Class to MenuPrescaleConfig and removing from all menu files
- With these changes, the failing tests from https://its.cern.ch/jira/browse/ATR-21963 and https://its.cern.ch/jira/browse/ATR-21958 should now work.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TriggerCommon/TriggerMenuMT
Adding @bernius as watcher
added Trigger TriggerMenu master review-pending-level-1 labels
This merge request affects 1 package:
- Trigger/TriggerCommon/TriggerMenuMT
Adding @bernius as watcher
CI Result FAILURE (hash aaaef28c)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19924] CI Result FAILURE (hash 33feaa3a)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19927]Please fix compiler warning
# CMake ---> /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/Python/3.7.6/x86_64-centos7-gcc8-opt/bin/python3.7 /build2/ci-builds/master/Athena/build/Athena/Trigger/TriggerCommon/TriggerMenuMT/CMakeFiles/python_HLTMenuConfig_MenuPhysicsP1_HI_run3_v1pycGen.py /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/PhysicsP1_pp_run3_v1.py:146:5: warning: F401 'TriggerJobOpts.TriggerFlags.TriggerFlags' imported but unused from TriggerJobOpts.TriggerFlags import TriggerFlags ^ warning: Python code violations found. See <https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/flake8_atlas>.
and the failed
unit-test
The following tests FAILED: 1821 - TriggerMenuMT_flake8_ctest (Failed) [ERROR_MESSAGE] Errors while running CTest
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 1 package:
- Trigger/TriggerCommon/TriggerMenuMT
Adding @bernius as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash b7df358d)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20017]added review-approved label and removed review-pending-level-1 label
mentioned in commit be7118a9
added sweep:ignore label