Add some minbias tests comparing against offline tracks

Add some minbias tests comparing against offline tracks, also replace one of the existing minbias tests with the new, improved configuration code to remove most of the duplicated code

Modify the key in the json file to reduce the number of things that need to be independently changed

Move files needed only for release 21.3 to a new obsolete directory. As soon as it is established these are no longer needed, this obsolete directory will be removed

WARNING: big files (>100K) are found in the changeset

2160K in file Trigger/TrigValidation/TrigInDetValidation/obsolete/InDetModules.py

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

added Trigger master review-pending-level-1 labels

added 1 commit

• a968e54d - Fix incorrect signature flag

Compare with previous version

WARNING: big files (>100K) are found in the changeset

2160K in file Trigger/TrigValidation/TrigInDetValidation/obsolete/InDetModules.py

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

added 1 commit

• b40bf0f8 - update remaining mibias job

Compare with previous version

WARNING: big files (>100K) are found in the changeset

2160K in file Trigger/TrigValidation/TrigInDetValidation/obsolete/InDetModules.py

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

added 1 commit

• 56c88fe5 - Trivial job description change

Compare with previous version

WARNING: big files (>100K) are found in the changeset

2160K in file Trigger/TrigValidation/TrigInDetValidation/obsolete/InDetModules.py

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

CI Result FAILURE (hash 429c18fa)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19959]

So now the CI test runs all our nightly tests ? This is nonsense - the point of these tests are to run in the nightlies not to run the wntire set of tests as part of the CI tests. The point is to have them in the release as quickly as possible to see the results in the test not to run them as a check before the get submitted. If we wanted that they would have to be run with fewer events. Can we have these removed from the CI tests please.

Thanks Mark

CI Result SUCCESS (hash a968e54d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19962]

CI Result SUCCESS (hash 56c88fe5)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19971]

CI Result SUCCESS (hash b40bf0f8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19970]

Hi @sutt, Do you need to add extra "offline" minbias tests?? Couldn't we just add the plots using offline reference to the standard test - as we do for other tests?

Cheers Julie

Hi Julie, indeed we should not need extra tests - as you say we can do both the offline and truth comparisons from the same job, but at the moment, this would need running the post processing twice, and would need a solution to how best to display them in the web display so we could see the results from both.

So for the time being, since it is important to see the output already, I have simply added some additional tests, and we should remove them at such as time as we have decided on and implemented any developments for the web display.

Cheers Mark

Hi @sutt , Tim already added the switch on the webdisplay, e.g. here: https://idtrigger-val.web.cern.ch/idtrigger-val/TIDAWeb/TIDAart/?hpage=efeff&jobdir=master/Athena/x86_64-centos7-gcc8-opt/2020-09-05T2101/TrigInDetValidation/test_trigID_el_singlee_7-80-1

Cheers Julie

Only minor cleaning comments from L1, bumping to L2 for final signoff

added review-pending-level-2 label and removed review-pending-level-1 label

The cosmic jo are for development, so it is useful to leave in the commented code at the moment - I changed them by just reformatting them to aid readability. At some point this file will be removed once other changes have been completed and the code moved elsewhere.

Cheers Mark

resolved all threads

Many thanks Edson,

Cheers Mark

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit b2fc8cc8

added sweep:ignore label