drop unused tau variable, and code cleanup

Hello,

This MR is dropping a few variables that are not used anywhere in the tau reconstruction:

• TauJetParameters::LC_pantau_interpolPt: we now use an Et-resolution weighted average between calo pt and substructure pt as input to the MVA pt, no longer an interpolated pt
• TauJetParameters::SumPtTrkFracCorrected and TauJetParameters::innerTrkAvgDistCorrected: we no longer use pileup-corrected BDT inputs

I have checked it does not change the reconstruction output, besides the 3 variables that are now gone. Impressive size reduction of the TauJets container in the xAOD by 0.8% :-)

I also dropped all the initalize/finalize override methods that were trivially returning SUCCESS.

Code cleanup was also done on a best-effort basis.

Cheers, Bertrand

added Reconstruction Tau master labels

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added review-pending-level-1 label

added 1 commit

• af72be67 - drop 2 more deprecated variables, and fix indentation

Compare with previous version

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added 1 commit

• 7b734a1b - minor

Compare with previous version

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

marked as a Work In Progress

changed the description

added 1 commit

• 22a91b55 - drop override methods that simply return SUCCESS

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: drop unused tau variable to drop unused tau variable, and code cleanup

changed the description

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

CI Result SUCCESS (hash c02c23d4)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19961]

CI Result SUCCESS (hash 7b734a1b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19966]

CI Result SUCCESS (hash af72be67)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19963]

CI Result SUCCESS (hash 22a91b55)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19972]