tauRecTools: improve CombinedP4FromRecoTaus

Hello,

This MR is trying to improve and clean up CombinedP4FromRecoTaus on a best-effort basis, although it could be further improved by avoiding code duplication (many functions are very similar and could be streamlined). Function arguments are now const references. Two weaknesses have been identified: the code will misbehave for 2-prong taus that we intend to support in R22, and for detector upgrade (hardcoded 2.7 |eta| cut). To be improved.

Note: systematically moving to const references was motivated by code readability, but may be sub-optimal in terms of performance. To be followed up.

Cheers, Bertrand

added Reconstruction Tau master labels

Tagging @cgrefe , @adbailey , @xiaozhon , @gipezzul for information.

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 1ab625c3)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19975]

changed the description

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• fb20419d - implemented comments

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/TauID/TauAnalysisTools
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added Analysis review-pending-level-1 labels and removed review-user-action-required label

resolved all threads

Thanks @jojungge . Everything should be fixed now.

added review-approved label and removed review-pending-level-1 label

CI Result SUCCESS (hash fb20419d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20048]

mentioned in commit 2272dc30

merged

added sweep:ignore label