Skip to content
Snippets Groups Projects

Athena preparation for HepMC3

Merged Athena preparation for HepMC3
averbyts/athena:HepMC3AthenaPreparation1 into master
Merged Andrii Verbytskyi requested to merge averbyts/athena:HepMC3AthenaPreparation1 into master

In this MR: Athena preparation for HepMC3 Mostly simple replacements. Of ofld HepMC2 functions with AtlasHepMC functions that can handle HepMC2 and HepMC3.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Simulation/FastShower/FastCaloSim
    • Simulation/FastSimulation/FastChainPileup
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_SimulationSelectors
    • Simulation/Tools/McEventCollectionFilter

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot added Simulation master review-pending-level-1 labels

    added Simulation master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash d2329289)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20001]

  • Andrii Verbytskyi added 5 commits

    added 5 commits

    • d2329289...01cd7237 - 4 commits from branch atlas:master
    • 965795b7 - Merge remote-tracking branch 'upstream/master' into HepMC3AthenaPreparation1

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

  • Andrii Verbytskyi added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Simulation/FastShower/FastCaloSim
    • Simulation/FastSimulation/FastChainPileup
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/Tools/McEventCollectionFilter

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Simulation/FastShower/FastCaloSim
    • Simulation/FastSimulation/FastChainPileup
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/Tools/McEventCollectionFilter

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 965795b7)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 1
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20005]

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Developer

    Please fix the compilation error

    # CMake ---> /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DATLAS_GAUDI_V21 -DCLHEP_ABS_DEFINED -DCLHEP_MAX_MIN_DEFINED -DCLHEP_SQR_DEFINED -DGAUDI_V20_COMPAT -DHAVE_64_BITS -DHAVE_GAUDI_PLUGINSVC -DISF_SimulationSelectors_EXPORTS -DPACKAGE_VERSION="ISF_SimulationSelectors-00-00-00" -DPACKAGE_VERSION_UQ=ISF_SimulationSelectors-00-00-00 -DSIMULATIONBASE -D__IDENTIFIER_64BIT__ -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Generators/AtlasHepMC -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/Barcode/BarcodeServices -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaBaseComps -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/DataModelRoot -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinks -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/SGTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/StoreGate -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthAllocators -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/PersistentDataModel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_Core/ISF_Event -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/AtlasTest/TestTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/AtlasDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/IdDict -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/Identifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/Barcode/BarcodeEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Generators/GeneratorObjects -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTruth -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_Core/ISF_Interfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/G4Sim/TrackRecord -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/HitManagement -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_Tracking/ISF_TrackingInterfaces -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/ROOT/v6.20.06/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/HepPDT/2.06.01/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/HepMC/2.06.11/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/AthSimulation/install/GAUDI/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/Boost/1.72.0/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/tbb/2020_U1/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/Python/3.7.6/x86_64-centos7-gcc8-opt/include/python3.7m -isystem /cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/include/python3.7m -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/CORAL/3_2_4/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/AthSimulation/install/AthSimulationExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_97apython3_ATLAS_1/eigen/3.3.7/x86_64-centos7-gcc8-opt/include/eigen3 -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -o CMakeFiles/ISF_SimulationSelectors.dir/src/TruthAssocSimSelector.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/src/TruthAssocSimSelector.cxx
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/src/TruthAssocSimSelector.cxx: In member function 'virtual bool ISF::TruthAssocSimSelector::passSelectorCuts(const ISF::ISFParticle&) const':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_SimulationSelectors/src/TruthAssocSimSelector.cxx:76:98: error: no matching function for call to 'ISF::HepMCHelper::findRealtiveWithPDG(HepMC::GenParticle*&, const HepMC::IteratorRange&, const std::set<int>&)'
           auto  relative = HepMCHelper::findRealtiveWithPDG( genParticle, m_relation, m_relatives);
                                                                                                  ^
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/ISF/ISF_Core/ISF_Event/ISF_Event/HepMCHelper.h:62,
  • Johannes Junggeburth added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • A
    Andrii Verbytskyi @averbyts ·
    Author Developer

    Jenkins please retry a build

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Despite what gitlab says, a pipeline is currently running for 0c21a99a :
    https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-CC7/20006/

  • A
    Andrii Verbytskyi @averbyts ·
    Author Developer

    Hi @jchapman ,

    yes, thanks!

    Again, jenkins is bad...

    Best regards,

    Andrii

  • Andrii Verbytskyi added 56 commits

    added 56 commits

    • 0c21a99a...26f926a4 - 55 commits from branch atlas:master
    • cd78aa11 - Merge remote-tracking branch 'upstream/master' into HepMC3AthenaPreparation1

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Simulation/FastShower/FastCaloSim
    • Simulation/FastSimulation/FastChainPileup
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/Tools/McEventCollectionFilter

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 0c21a99a)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20006]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash cd78aa11)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20043]

  • Johannes Junggeburth added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 251cd6c0

    mentioned in commit 251cd6c0

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

Please register or sign in to reply