Skip to content
Snippets Groups Projects

Fix for CSC RDO to PRD decoding in non-MT decoding tool

Merged Savanna Shaw requested to merge sshaw/athena:csc-rdoroprd into master

In cases where we run the seeded decoding more than once per event, we were missing storing the output PRDs in events where we processed more than one RoI per event. This fixes that problem (and effects only the non-MT version of the tool used only for the legacy Run 2 trigger).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • There are change suggestions open, otherwise looks good --L1

  • Savanna Shaw added 1 commit

    added 1 commit

    Compare with previous version

  • Savanna Shaw resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools

    Adding @rosati ,@nkoehler ,@wleight as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash c2b0dbe6)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20059]

  • Savanna Shaw added 1 commit

    added 1 commit

    • 17738e08 - fix check on object retrieval

    Compare with previous version

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools

    Adding @rosati ,@nkoehler ,@wleight as watchers

  • :white_check_mark: CI Result SUCCESS (hash 17738e08)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20070]

  • Looks good, approving --L1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading