Skip to content

sweep data handles and associated changes from master into 21.2

Nils Erik Krumnack requested to merge krumnack/athena:sweep_data_handles into 21.2

There were a couple of people asking for this to become available in 21.2 (among others I believe @dguest) to allow keeping tools fully in sync between master and 21.2.

As this code has already been reviewed in master, this should get a stream-lined review with only "essential" comments. Any substantial updates should go into a separate MR into master which can then be swept at a later point.

This update contains a lot of commented out code that is in master as well. That is intentional and will be cleaned up at a later point.

Also used this MR to fix a compiler warning I got with the latest clang on MacOS.

List of commits cherry-picked (I removed any changes outside of Control/AthToolSupport):

  • 784f956c make a demo version of an AsgDataHandles package
  • acde5682 fix include guards and forward to StoreGate in Athena
  • 7fee5f0f extend and clean up the data handle interfaces/implementations
  • 19b58d3d remove unused files
  • 9f2f275e add/fix packages for AnalysisBase
  • 21952e6a fixes for clang on MacOS
  • e09ad437 AsgTools: Fix cppcheck warnings.
  • 059330c3 fix typo
  • 448d7224 add another test for setting boolean values
  • 0a4a17da fix some const-issues
  • 292f57c2 add missing include
  • 2218817a add a unit test for AsgDataHandles
  • 025454bf protect include with conditional compilation
  • 76c5b299 disable DataHandleTest code in AthSimulation
  • 1af39479 fix include guard
  • 3359a85a AthToolSupport: remove atlas_depends_on_subdirs
  • b3bd1593 add basic ReadDecorHandle
  • e7f35692 add Gaudi::Hive::currentContext()
  • 4cf338bb add more incident types that need to be handled
  • f3d01053 add first version of WriteHandle/WriteHandleKey for AnalysisBase
  • 82fa41c0 fix compiler warning
  • 1925ef93 const-retrieve recorded container
  • 22f385d4 add Gaudi::Property, plus extra handle capabilities
  • edbf625b add ReadHandleKeyArray, plus other data handle updates
  • 8a7fc6fd add more functionality to data handles
  • 699cd219 add EventStoreType, extend Property wrapper functionality

Merge request reports