Update Likelihood for new Ambiguity type from !35293
There is a rather long comment on the code.
The issue is that now we have an additonal type due to !35293 (merged) which we want to keep for electrons
The other part of the issue is that the "cut" is on config txt in GroupArea, and the criterion is 31 ... i.e a hard coded magic number not in "code"
Obviously a better solution can come with the new tunes, when we will update configs. Then I hope my long comment in the code will get removed, as the tuning will progress after the freeze and validation.
For now doing a best effort patch and adding a comment.
Mentioning @turra , @psommer , @okiverny @dboerner , @ludovica
Merge request reports
Activity
added Analysis Derivation Egamma master review-pending-level-1 labels
removed Analysis Derivation Egamma master review-pending-level-1 labels
added Analysis Derivation Egamma master labels
CI Result SUCCESS (hash f1f9df05)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20105]This merge request affects 2 packages:
- PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools
- PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces
Adding @akraszna as watcher
added review-pending-level-1 label
removed review-pending-level-1 label
added review-pending-level-1 label
CI Result SUCCESS (hash 82517277)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20133]added review-approved label and removed review-pending-level-1 label
mentioned in commit e7eb34dd
added sweep:ignore label