Final(?) tweaks to ID track silicon seeding

This MR adds some small further performance tweaks to the seeding phase of ID track reconstruction, as part of the ATLIDTRKCP-260 optimization round:

• The z0 interval for track reconstruction is reduced from 250 to 200mm
• veto of some specific 'impossible' regions for the seed's central space point (for example, first/last layers or top of a disk)
• increase min delta R between consecutive SP in a seed from 5 to 10mm
• update of the space point map in the seed maker event data to allow it to grow in size if needed, allowing a smaller size in memory when starting out (200 rather than 5k slots)
• Improve documentation of the logic being used in the seed maker

The changes should leave the tracking efficiency stable at sub-permille level, while the fake rate is reduced by around 10%. The CPU time for the track finding step should improve by slightly below 10 percent, with slight downstream profits to the ambiguity resolution and track extension, and a 3-4% improvement in overall tracking CPU. A detailed discussion of the changes is available in these slides.

Adding @norap and @sroe. Also including @amete for information in case this shows up in SPOT.

added Tracking master labels

changed the description

Given that today is the anniversary of the LHC start, we should celebrate a new philosopher of the day

Although the old one has not been solved yet ;-)

resolved all threads

added 4 commits

• 8e2f8ceb - add optional update to seed confirmation strategy
• 042cc349 - upps, forgot the most important one
• 722ab3b4 - add some further documentation
• 779c6662 - protect the heavy ions from my changes

Compare with previous version

added 1 commit

• bd849103 - clean up changes we do not wish to deploy, and add further documentation

Compare with previous version

changed the description

added 601 commits

• bd849103...54e9d5a1 - 600 commits from branch atlas:master
• 34a67056 - Merge remote-tracking branch 'upstream/master' into master-tuneTrackFinderFurther

Compare with previous version

unmarked as a Work In Progress

changed the description

added Run2-DataReco-output-changed label

WARNING: big files (>100K) are found in the changeset

104K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ATLxk.cxx

This merge request affects 3 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added InnerDetector review-pending-level-1 labels

changed the description

CI Result FAILURE (hash 34a67056)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20485]

Tests failing due to different number of tracks, i.e.

         run       event       nTopo   nIdTracks       nJets      nMuons
3,5c3,5
<       330470  1183722342         394         411          20           0
<       330470  1183727953         532         572          11           4
<       330470  1183732647         467         451          13           1
---
>       330470  1183722342         394         406          20           0
>       330470  1183727953         532         566          11           4
>       330470  1183732647         467         449          13           1

added review-user-action-required label and removed review-pending-level-1 label

added 31 commits

• 34a67056...fed236f6 - 29 commits from branch atlas:master
• 075ec23b - Merge remote-tracking branch 'upstream/master' into master-tuneTrackFinderFurther
• c6f9a11a - update q-test ref files for xAODDigest tests

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ATLxk.cxx

This merge request affects 4 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
• Tools/PROCTools

Adding @goetz ,@amorley ,@amete ,@gavrilen ,@sroe ,@jsandesa as watchers

added Tools review-pending-level-1 labels and removed review-user-action-required label

added Egamma label

added review-approved label and removed review-pending-level-1 label

CI Result SUCCESS (hash c6f9a11a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20542]

resolved all threads

merged

mentioned in commit f8d5f496

added sweep:ignore label

mentioned in merge request !36429 (merged)