RpcRawDataMonitoring: Fix identifier validation test.

Calling Identifier::is_valid() is not the same as the isValid flag returned by RpcIdHelper.

Fixes (not entirely reproducible) crash seen with q222.

This merge request affects 1 package:

• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring

Adding @rosati ,@nkoehler ,@wleight as watchers

added DQ MuonSpectrometer master review-pending-level-1 labels

Hi @ssnyder,

yes, the is_valid() method is not as strong as the idHelper check, however, the idHelper check is terribly slow. I changed it in some places because @istin reported slow monitoring code. At the moment, he is running some checks on master,latest. This change could make it slower again.

I am on holiday this week, so I won‘t be able to check before Monday.

Best, Nico

tagging the correct @amete

CI Result SUCCESS (hash acf4c946)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20132]

But unfortunately, as things are, the code can proceed with identifiers which are in fact invalid, sometimes leading to crashes (i think due to an out-of-bounds array access).

If you're gone this week, i'd suggest we go ahead and merge this; you can later look into doing this better.

resolved all threads

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3958e35d

added sweep:ignore label

To be a bit more concrete: without this MR, i see that the ESDtoAOD step of q222 fails about 50% of the time with an error like this:

{noformat} 18:56:02 RpcRawMonManager FATAL Standard std ::exception is caught 18:56:02 RpcRawMonManager ERROR File: /build/atnight/localbuilds/nightlies/master/athena/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MuonDetectorManager.cxx, Line: 1035 18:56:02 MuonDetectorManager::getRpcReadoutElement() - stNameindex out of range 12 0-11 {noformat}

resolved all threads