Enabling grooming on HLT PF/CSSK jets

The generation of the ungroomed jet definition didn't quite work for PF jets because we were making an ungroomed definition by hand. Restructured the jet reco sequence to be a little more modular, and return the jet definition so we can actually use this.

This then allows us to add a variety of CSSK+PF groomed jet collections to the testing menu.

Also now passes real ConfigFlags through the jet configuration, allowing us to read the metadata, and correctly configure the in situ calibration when it is wanted on data, and omit it on MC. This changes a few of the MC counts because previously we applied the in situ calibration all the time for consistency with a Run 2 bug.

@jbossios

unmarked as a Work In Progress

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added JetEtmiss Reconstruction Trigger TriggerEDM TriggerMenu master review-pending-level-1 labels

Note: Addresses the AthenaMT side of ATR-21949

CI Result FAILURE (hash 6bdbc8fc)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20148]

Looks like the HLT jet finder found a different set of jets, which might be expected from the MR. If they are correct, then the test comparison file needs to be updated.

--- /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/data/TriggerTest/ref_data_v1Dev_build.ref	2020-09-09 21:00:13.739527600 +0200
+++ ref_data_v1Dev_build.ref.new	2020-09-10 00:25:16.641218860 +0200
@@ -20,10 +20,10 @@
 TrigSignatureMoniMT                                 INFO -- #3965466087 Events         20         20         0          0          0          0          -          -          -          -          -          -          -          -          0          
 TrigSignatureMoniMT                                 INFO -- #3965466087 Features                             0          0          0          0          -          -          -          -          -          -          -          -          
-TrigSignatureMoniMT                                 INFO HLT_2j330_a10sd_ftf_csskpf_35jmassINF_nojcalib_L1J100 #637459819
-TrigSignatureMoniMT                                 INFO -- #637459819 Events          20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
-TrigSignatureMoniMT                                 INFO -- #637459819 Features                              0          0          0          0          0          0          0          0          0          0          0          -          
-TrigSignatureMoniMT                                 INFO HLT_2j330_a10sd_ftf_csskpf_jes_35jmassINF__L1J100 #1560717259
-TrigSignatureMoniMT                                 INFO -- #1560717259 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
-TrigSignatureMoniMT                                 INFO -- #1560717259 Features                             0          0          0          0          0          0          0          0          0          0          0          -          
+TrigSignatureMoniMT                                 INFO HLT_2j330_a10sd_csskpf_35jmassINF_ftf_nojcalib_L1J100 #2578247434
+TrigSignatureMoniMT                                 INFO -- #2578247434 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
+TrigSignatureMoniMT                                 INFO -- #2578247434 Features                             0          0          0          0          0          0          0          0          0          0          0          -          
+TrigSignatureMoniMT                                 INFO HLT_2j330_a10sd_csskpf_jes_35jmassINF_ftf__L1J100 #1614810053
+TrigSignatureMoniMT                                 INFO -- #1614810053 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
+TrigSignatureMoniMT                                 INFO -- #1614810053 Features                             0          0          0          0          0          0          0          0          0          0          0          -          
 TrigSignatureMoniMT                                 INFO HLT_2j330_a10t_lcw_35jmassINF_nojcalib_L1J100 #2090406211
 TrigSignatureMoniMT                                 INFO -- #2090406211 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
@@ -326,22 +326,22 @@
 TrigSignatureMoniMT                                 INFO -- #3875082669 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
 TrigSignatureMoniMT                                 INFO -- #3875082669 Features                             0          0          0          0          0          0          0          0          0          0          0          -          
-TrigSignatureMoniMT                                 INFO HLT_j460_a10sd_ftf_csskpf_35jmassINF_nojcalib_L1J100 #2476757089
-TrigSignatureMoniMT                                 INFO -- #2476757089 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
-TrigSignatureMoniMT                                 INFO -- #2476757089 Features                             0          0          0          0          0          0          0          0          0          0          0          -          
-TrigSignatureMoniMT                                 INFO HLT_j460_a10sd_ftf_csskpf_jes_35jmassINF_L1J100 #752585520
-TrigSignatureMoniMT                                 INFO -- #752585520 Events          20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
-TrigSignatureMoniMT                                 INFO -- #752585520 Features                              0          0          0          0          0          0          0          0          0          0          0          -          
-TrigSignatureMoniMT                                 INFO HLT_j460_a10sd_ftf_csskpf_jes_L1J100 #1698622899
-TrigSignatureMoniMT                                 INFO -- #1698622899 Events         20         20         0          0          0          0          0          0          0          0          0          0          0          -          0          
-TrigSignatureMoniMT                                 INFO -- #1698622899 Features                             0          0          0          0          0          0          0          0          0          0          0          -          

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• a2a5cdfd - Homogenising the jet chain argument ordering

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-user-action-required label

@suyogs @cvarni @sekula FYI we decided to make sure that all jet chain names followed the convention: jX_[jetalg]_[inputtype]_[inputcalib]_[jetcalib]_[tracking]

For the b-jet part of the current menu, this means we moved ftf to the end of the jet part, and before the b-jet part. Functionally the parsing doesn't care, but it makes things less confusing for human readers.

added 1 commit

• 6d42bdb9 - Revert premature smc --> jmass renaming

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added 1 commit

• 65c2af0a - Revert premature smc --> jmass renaming

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 6d42bdb9)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 12, warnings 22
AthSimulation: number of compilation errors 5, warnings 0
AthGeneration: number of compilation errors 17, warnings 2
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20209]

CI Result FAILURE (hash 65c2af0a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20211]

CI Result SUCCESS (hash a2a5cdfd)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20208]

added 1 commit

• 56a7dd9b - Remove debug printouts

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 56a7dd9b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20217]

added 2 commits

• af544991 - Revert premature smc --> jmass renaming
• 301a4e77 - Remove debug printouts

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 301a4e77)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20249]

added 245 commits

• 301a4e77...4995f25a - 227 commits from branch atlas:master
• 9c4064ab - Add a jet chain using R=1.0 LCTopo Soft Drop jets
• a020019d - Update references
• 5396d31a - Adding SD CSSK (jes, and nojcalib) chains
• b2147c0c - Start restructuring jet trigger sequence setup
• de96b892 - Splitting up jetRecoSequence
• b2e1feb7 - fixing obvious errors caught by compiler
• 96d27861 - correcting argument handling
• a74ffc91 - kwargs
• 0a0ac62d - kwargs
• 8d851a9a - Adaptation to set up PFlow groomed trigger jets
• 9dd6632a - Add config flag access to DecisionHandling.jetMenuHelper
• c154618a - Fixes to MET end
• bcaa7788 - Updating refs
• 0e6d6830 - Tentatively commit ref update but check the changes to various chains
• 579011bf - Homogenising the jet chain argument ordering
• ca412ae6 - Revert premature smc --> jmass renaming
• ce0c25e4 - Remove debug printouts
• 2f41f84c - Fix up refs for smc chains

Compare with previous version

WARNING: big files (>100K) are found in the changeset

164K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

168K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 2f41f84c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20352]

Failing tests are showing up in several MR and are unrelated, approving.

added review-approved label and removed review-pending-level-1 label

added 24 commits

• 2f41f84c...18792d6c - 23 commits from branch atlas:master
• 18dc7699 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom

Compare with previous version

WARNING: big files (>100K) are found in the changeset

156K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

160K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-approved label

CI Result FAILURE (hash 18dc7699)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20391]

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

156K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

160K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 18dc7699)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20427]

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

156K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

160K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 18dc7699)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20459]

Hi TJ,

Probably you need to further modify the ref file to match the new outputs. For example:

TrigSignatureMoniMT INFO -- #4034799151 Events
TrigSignatureMoniMT INFO -- #4034799151 Features
-TrigSignatureMoniMT INFO HLT_j225_ftf_subjesgscIS_bmv2c1040_split_L1J100 #3992507557

-TrigSignatureMoniMT INFO -- #3992507557 Events
-TrigSignatureMoniMT INFO -- #3992507557 Features
+TrigSignatureMoniMT INFO HLT_j225_subjesgscIS_ftf_bmv2c1040_split_L1J100 #219711753

+TrigSignatureMoniMT INFO -- #219711753 Events
+TrigSignatureMoniMT INFO -- #219711753 Features
TrigSignatureMoniMT INFO HLT_j260_320eta490_L1J20 #3084792704

TrigSignatureMoniMT INFO -- #3084792704 Events

Hope this help in fixing the problem.

Michele, L1 reviewer

added review-user-action-required label and removed review-pending-level-1 label

added 108 commits

• 18dc7699...54e9d5a1 - 106 commits from branch atlas:master
• aba83069 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom
• d042ff0b - Updating refs yet again

Compare with previous version

added 54 commits

• d042ff0b...5cadef22 - 53 commits from branch atlas:master
• bc6fc57b - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom

Compare with previous version

added urgent label

WARNING: big files (>100K) are found in the changeset

168K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

172K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

Adding urgent label as this keeps picking up conflicts, despite having been approved already once.

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash bc6fc57b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20572]

Hello, there are still errors related to trigger tests. Could you please have a look into that? Thanks, Pienpen (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• ee00ea83 - Ordering of 2g50_loose in refs

Compare with previous version

WARNING: big files (>100K) are found in the changeset

168K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_mt1_build.ref

172K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash ee00ea83)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20594]

Test (finally!) pass, and all threads resolved. L1 approving (again).

added review-approved label and removed review-pending-level-1 label

Hi @khoo,

this MR picked up a conflict, unfortunately.

• Walter

added review-user-action-required label

added 70 commits

• ee00ea83...6cdec426 - 67 commits from branch atlas:master
• d84902c5 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom
• 8168de11 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom
• 421854b5 - Update refs again

Compare with previous version

WARNING: big files (>100K) are found in the changeset

168K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

172K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-approved review-user-action-required labels

CI Result FAILURE (hash 421854b5)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20622]

added full-build label

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

168K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

172K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

build area is cleaned as MR is labeled as full-build

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

CI Result FAILURE (hash 421854b5)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20634]

Hi @khoo

The compilation warnings are not related. test_trigAna_RDOtoRDOTrig_v1Dev_build failed, could you have a look ?

Cheers, Xiaozhong (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 4 commits

• 421854b5...f58c75cf - 2 commits from branch atlas:master
• 90a112dc - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-HLT-PF-Groom
• 18cf26f8 - Yet another ref fix

Compare with previous version

WARNING: big files (>100K) are found in the changeset

168K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

172K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

build area is cleaned as MR is labeled as full-build

This merge request affects 6 packages:

• Reconstruction/Jet/JetCalibTools
• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@sutt ,@okumura ,@jpanduro ,@mleblanc ,@bernius ,@tamartin ,@okuprash ,@mdaneri ,@jbossios as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 18cf26f8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20657]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7d113e29