Add potential fix to prd association bug ATLIDTRKCP-274

ATLIDTRKCP-274 describes an issue discovered when running with LRT for run-3 validations where the number of shared hits on tracks from the primary pass were increase when enabling LRT. Further investigation showed that this issue was also present in release 21 and impacts LRT as well as back-tracking.

This MR addresses part of this issue, where the use of the PRDAssociation was not propagated in the correct order when setting all the tools for the TrackFinder as the tools were initialised before setAssociation() was executed. The useAssociation flag in the SiTrajectoryElement_xk was thereby always false.

The fix seems to give the expected results, minor reduction to LRT efficiency but reduction of fakes by 50%. Further details are on: https://its.cern.ch/jira/browse/ATLIDTRKCP-274 showing small scaled validation tests. It would be great to get this merged and we can follow up on the minor that's remaining to understand.

FYI @sroe @goblirsc

added InnerDetector Run2-DataReco-output-changed Tracking master labels

unmarked as a Work In Progress

changed the description

This merge request affects 1 package:

• InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk

Adding @goetz ,@gavrilen ,@sroe ,@amorley ,@jsandesa as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash f3a24871)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20666]

removed Run2-DataReco-output-changed label

added bugfix label

added urgent label

removed review-pending-level-1 label

resolved all threads

added review-pending-level-1 label

resolved all threads

resolved all threads

The pipeline warnings are unrelated to this MR and I'm quite happy with it. But, I think the most pending item from assigning approval, is the philosopher of the day. I'm very proud to offer a very famous one today

[L2 shifter]

added review-approved label and removed review-pending-level-1 label

added review-pending-level-1 label and removed review-approved label

added review-approved label and removed review-pending-level-1 label

Hi, thanks @mfauccig and @jojungge! I think this is okay to approve now.

merged

mentioned in commit 57983309

added sweep:ignore label

mentioned in merge request !41496 (merged)