Skip to content
Snippets Groups Projects

Trigger config loading - schema tracing and result reporting

Merged Joerg Stelzer requested to merge stelzer/athena:master-protectMenuLoading into master
All threads resolved!

The two trigger config databases (DEV1 and DEV2) now contain a new table which holds the schema version. Future DBs will also contain this table ( atlas-tdaq-software/TriggerDB!8 (merged) ). This enables us to apply potentially different queries to different databases, e.g. if schema evolution becomes necessary.

Also discussed in ATR-20803

This MR enables the db loading software to deal with this table and use the correct queries. This is the approach we already followed in Run 1 and 2.

Also the error reporting was improved, now different exception classes report different problems when loading configurations from the database. DataStructure now has a constructor that takes a string as name.

cc @mark @jpanduro @jshinner @landon

Edited by Joerg Stelzer

Merge request reports

Pipeline #1927973 failed

Pipeline failed for 2ff5b3c4 on stelzer:master-protectMenuLoading

Approval is optional

Merged by Walter LamplWalter Lampl 4 years ago (Sep 15, 2020 9:07am UTC)

Merge details

  • Changes merged into master with c0824e06 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gordon Watts
  • Gordon Watts
  • Gordon Watts
    • Large number of changes to trigger code.
    • I had a few minor comments
    • Those comments should not stop L2 or expert reviews from proceeding.
  • For the moment no additional comments.....

    Pavol [as L2 MR shifter]

    Edited by Pavol Strizenec
  • Joerg Stelzer added 1 commit

    added 1 commit

    • 2ff5b3c4 - Follow up on the software review

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigConfiguration/TrigConfData
    • Trigger/TrigConfiguration/TrigConfIO

    Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

  • Joerg Stelzer changed the description

    changed the description

  • :negative_squared_cross_mark: CI Result FAILURE (hash 2ff5b3c4)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :o: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 9, warnings 9
    :o: AthSimulation: number of compilation errors 3, warnings 0
    :o: AthGeneration: number of compilation errors 3, warnings 2
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20224]

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 2 packages:

    • Trigger/TrigConfiguration/TrigConfData
    • Trigger/TrigConfiguration/TrigConfIO

    Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 2ff5b3c4)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20348]

  • Failing tests are showing up in several MR and are unrelated. Code was already revied and I have no further comments, approving.

  • Walter Lampl resolved all threads

    resolved all threads

  • merged

  • Walter Lampl mentioned in commit c0824e06

    mentioned in commit c0824e06

  • Please register or sign in to reply
    Loading