Skip to content
Snippets Groups Projects

RingerSelectorTools+PATCore: Split off AcceptInfo/AcceptData into a separate library.

Merged RingerSelectorTools+PATCore: Split off AcceptInfo/AcceptData into a separate library.
ssnyder/athena:splitAccept.RingerSelectorTools-20200910 into master
All threads resolved!
Merged Scott Snyder requested to merge ssnyder/athena:splitAccept.RingerSelectorTools-20200910 into master
All threads resolved!

RingerSelectorToolsEnumDict is loaded during configuration, and cannot depend on Athena libraries or we may see failures with loading converters. It depends on PATCore, which used to have minimal dependencies, but now depends on AthenaBaseComps.

So PATCore is changed to split AcceptInfo/AcceptData into a separate library, which does have minimal dependencies. (The existing PATCore library then depends on this new library, so clients don't have to change.) RingerSelectorToolsEnumDict then changes to depend on this new library rather than PATCore.

Also cmake cleanups in RingerSelectorTools.

Merge request reports

Pipeline #1929983 passed

Stage: external

    Pipeline passed for 1a956c9d on ssnyder:splitAccept.RingerSelectorTools-20200910

    Approval is optional

    Merged by Walter LamplWalter Lampl 4 years ago (Sep 15, 2020 9:45am UTC)

    Merge details

    • Changes merged into master with 5952e805 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Scott Snyder added 1 commit

    added 1 commit

    Compare with previous version

  • S
    Scott Snyder @ssnyder ·
    Author Developer

    Thanks Nils. Let's see if this works better.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/AnalysisCommon/PATCore
    • PhysicsAnalysis/RingerSelectorTools

    Adding @krumnack as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1a956c9d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make N/A N/A N/A N/A
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests N/A N/A N/A N/A

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 597
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20281]

  • M
    Michele Faucci Giannelli @mfauccig ·

    Build failing due to: Generating ../../../x86_64-centos7-gcc8-opt/python/SiClusterizationTool/SiClusterizationToolConf.py, ../../../x86_64-centos7-gcc8-opt/lib/libSiClusterizationTool.confdb, genConf/SiClusterizationTool.conFATAL: command execution failed 00:14:13 java.io.EOFException

    Will try a rebuild

  • M
    Michele Faucci Giannelli @mfauccig ·

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/AnalysisCommon/PATCore
    • PhysicsAnalysis/RingerSelectorTools

    Adding @krumnack as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1a956c9d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 2, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20369]

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/AnalysisCommon/PATCore
    • PhysicsAnalysis/RingerSelectorTools

    Adding @krumnack as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1a956c9d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20418]

  • Michele Faucci Giannelli added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Walter Lampl resolved all threads

    resolved all threads

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit 5952e805

    mentioned in commit 5952e805

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply