Migrate MuonIdHelperSvc to MuonIdHelper in MdtDigitizationTool; add HPTDC...

Migrate MuonIdHelperSvc to MuonIdHelper in MdtDigitizationTool; add HPTDC ticksize to new BIS7 chambers. This is the same changes for MdtDigitizationTool as was done in Merge request 36196, just to separate out the MdtDigitizationTool from the other changes which had generated errors in RunTier0Tests.py. RunTier0Tests.log attached; no errors foundRunTier0Tests.log

This merge request affects 1 package:

• MuonSpectrometer/MuonDigitization/MDT_Digitization

Adding @jchapman ,@rosati ,@nkoehler ,@wleight as watchers

added Digitization MuonSpectrometer master review-pending-level-1 labels

CI Result FAILURE (hash f0791fc8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 9, warnings 8
AthSimulation: number of compilation errors 3, warnings 0
AthGeneration: number of compilation errors 3, warnings 2
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20230]

Jenkins please retry a build

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonDigitization/MDT_Digitization

Adding @jchapman ,@rosati ,@nkoehler ,@wleight as watchers

CI Result FAILURE (hash f0791fc8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20303]

the failing SimulationTier0Test_required-test in AthSimulation and the failing OverlayTier0Test_required-test and RecoPHYSFormatTest_optional-test in Athena are part of the nightly (cf. ATLINFR-3722).

Thanks for separating out these changes @diehl.
Cheers,
John

In principle, the old and new code should work identically. The hasHPTDC method returns TRUE for chamber using the HPTDC chip which includes BMG, but also the new BIS7 being installed in LS2. So the new code covers BMG as before, but will also handle the new BIS7. The old BIS78 chambers which the new BIS7 replaces, will get FALSE from hasHPTDC, so old data should not be affected. However, I don't understand why the new code fails some tests, need to understand what exactly is failing.

resolved all threads

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonDigitization/MDT_Digitization

Adding @jchapman ,@rosati ,@nkoehler ,@wleight as watchers

CI Result SUCCESS (hash f0791fc8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20432]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit cbe80458

added sweep:ignore label

mentioned in merge request !36430 (merged)