Use unique_ptr for tracks in MuonTrackSteeringTools

This MR switches to using unique_ptr for Track and MuPatTrack objects. In particular, MuPatTrack now stores a unique_ptr to the Track, rather than an (unnecessarily) const bare pointer. This should simplify the memory management for tracks and eliminates the need for some const_casts. Also, the MuonTrackSelectorTool previously used the ITrackSelectorTool interface, which did not include a non-const method. Since only one of the interface methods was actually used, and the MuonTrackSelectorTool itself is only used in MuonTrackSteering, I removed the interface and moved the code for the tool to MuonTrackSteeringTools.

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

108K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result FAILURE (hash 198bba89)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 8, warnings 1
AthSimulation: number of compilation errors 3, warnings 0
AthGeneration: number of compilation errors 3, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20265]

Jenkins please retry a build

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

108K in file MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooTrackFitter.cxx

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecToolInterfaces
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

CI Result FAILURE (hash 198bba89)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20313]

Looks like the Overlay test timed out, and these changes should have no effect on the simulation test. In fact, I checked another MR and it had the same test failures, so I doubt that these are connected to my changes.

the failing SimulationTier0Test_required-test in AthSimulation and the failing OverlayTier0Test_required-test and RecoPHYSFormatTest_optional-test in Athena are part of the nightly (cf. ATLINFR-3722).

added review-approved label

removed review-pending-level-1 label

merged

mentioned in commit 4995f25a

added sweep:ignore label