Skip to content
Snippets Groups Projects

Migrate PileUpMergeSvc and more RunDependent new config

Merged Migrate PileUpMergeSvc and more RunDependent new config
rtombs/athena:PUdigi2 into master
All threads resolved!
Merged Rupert Tombs requested to merge rtombs/athena:PUdigi2 into master
All threads resolved!

Implement new style configuration for PileUpMergeSvc; apply it to PileUp digitization config functions.

Migrate the rest of RunDependentConfig. Add EvtIdModifierSvcCfg to the pileup digitization configuration test, to test it.

Edited by Rupert Tombs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Simulation/Digitization
    • Simulation/G4Atlas/G4AtlasApps
    • Simulation/G4Utilities/MCTruthSimAlgs

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot added Digitization Simulation master review-pending-level-1 labels

    added Digitization Simulation master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 6bd32bb9)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20269]

  • Rupert Tombs marked as a Work In Progress

    marked as a Work In Progress

  • Rupert Tombs changed the description

    changed the description

  • Rupert Tombs removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Rupert Tombs added 15 commits

    added 15 commits

    Compare with previous version

  • Rupert Tombs
    Rupert Tombs @rtombs ·
    Author

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Simulation/Digitization
    • Simulation/G4Atlas/G4AtlasApps
    • Simulation/G4Utilities/MCTruthSimAlgs

    Adding @jchapman ,@vpascuzz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash ab7b5f52)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20330]

  • Rupert Tombs added 74 commits

    added 74 commits

    Compare with previous version

  • Rupert Tombs
    Rupert Tombs @rtombs ·
    Author

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Simulation/Digitization
    • Simulation/G4Atlas/G4AtlasApps
    • Simulation/G4Utilities/MCTruthSimAlgs

    Adding @jchapman ,@vpascuzz as watchers

  • Rupert Tombs resolved all threads

    resolved all threads

  • Rupert Tombs unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Rupert Tombs added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 862604c1)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20474]

  • Rupert Tombs
    Rupert Tombs @rtombs ·
    Author

    The warning is unrelated.

  • M
    Michele Faucci Giannelli @mfauccig ·

    The "add_modifier" method could probably be written in a more elegant way but I cannot think of a good solution right now. In general, the code is good but there are several files touched so passing to L2 for a second look.

  • Michele Faucci Giannelli added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Rupert Tombs
    Rupert Tombs @rtombs ·
    Author

    @mfauccig Thank you for the review. This "add_modifier" function simply follows its previous implementation.

  • Johannes Junggeburth added review-approved label and removed review-pending-level-2 label

    added review-approved label and removed review-pending-level-2 label

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit ae306b71

    mentioned in commit ae306b71

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Tadej Novak
  • Rupert Tombs mentioned in merge request !36480 (merged)

    mentioned in merge request !36480 (merged)

  • Rupert Tombs resolved all threads

    resolved all threads

  • Nicholas Styles
  • Nicholas Styles resolved all threads

    resolved all threads

    • Please register or sign in to reply