Use vector moving in BPhysHelper

Update BPhysHelper tools to use moves where appropriate

This merge request affects 1 package:

• Event/xAOD/xAODBPhys

Adding @wwalko ,@akraszna ,@abarton as watchers

added EDM master review-pending-level-1 labels

CI Result FAILURE (hash e129638d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20322]

Failing tests are showing up in several MR and are unrelated, approving.

added review-approved label and removed review-pending-level-1 label

Hi Adam,

Was there any performance reason why you went with move operations instead of passing around const references? Did you actually see in some performance measurement that this makes a difference?

Don't get me wrong, fixing the std::string pass-by-value arguments is very welcome. But I really think that just rigorously fixing all function arguments to be passed as constant references would've been the way to go in this package.

Cheers, Attila

added review-user-action-required label and removed review-approved label

added 1 commit

• 4757563b - Use vector moving in BPhysHelper

Compare with previous version

This merge request affects 1 package:

• Event/xAOD/xAODBPhys

Adding @wwalko ,@akraszna ,@abarton as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 4757563b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20385]

There are still threads to resolve, and waiting on resolution of https://its.cern.ch/jira/browse/ATEAM-652 for the diff-root problems, and https://sft.its.cern.ch/jira/browse/SPI-1708 for the gperftools/tcmalloc issue.

resolved all threads

Jenkins please retry a build

This merge request affects 1 package:

• Event/xAOD/xAODBPhys

Adding @wwalko ,@akraszna ,@abarton as watchers

CI Result SUCCESS (hash 4757563b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20437]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 01cf41a2

added sweep:ignore label