Remove unused ctide features master

• Remove support for unused calorimeter ROIs and handling of b track candidates.
• Remove unused pixel covariance correction for collimated tracks:
  • remove the pixel covariance correction,
  • remove dRmap based identification of collimated tracks,
  • remove creation of dRmap.

All of the above is unused and was not properly migrated to athenaMT.

WARNING: big files (>100K) are found in the changeset

116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

This merge request affects 5 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetExample/InDetTrigRecExample
• InnerDetector/InDetRecTools/SiClusterOnTrackTool
• Tracking/TrkTools/TrkAmbiguityProcessor

Adding @goetz ,@sutt ,@amorley ,@gavrilen ,@sroe ,@nagano ,@jsandesa ,@bernius as watchers

added InnerDetector Tracking Trigger master review-pending-level-1 labels

@goblirsc, @npetters, @gfacini, @battagl: please check that these feature are not going to be reconsidered.

We are still working on the implementation for the trigger, so might need some of these features but it is too soon to know what will, or will not be needed at the moment.

Cheers Mark

Are You also planning to properly migrate these features to athenaMT: the ROI preparation should become alg, conditions data handling conditions alg needs to be introduced; the dRmap handling was not fully correct ?

Hi Goetz, I can't answer your question. I probably won't be implementing this myself, and have no idea what will, or will not be needed. Out of interest, if these features are not needed offline, is there anything to replace them ? If offline will not using them, then we will probably not be trying to use them online if we are not using them already. But if there are replacements that being added that we might need to use in the trigger, then it might be helpful to know of them in case we would need changes to the interfaces or anything of that nature.

Cheers Mark

Hi Mark, I am not aware of anybody working on reconsidering these features.

The special pixel covariance scaling for collimated tracks was implemented in 2016 and as far as I know hasn't been used.

The calo seeded special refit of b-decay candidate tracks was implemented in 2018, but as far as I know hasn't been run through a physics validation.

Both seem to be features which are not supported by offline track reconstruction, it seems to me.

Cheers, Götz

Hi @goetz,

Neither feature is being considered at the moment for the offline reconstruction.

If we need to revisit the idea of an ROI, then we will put the ROI preparation back in as an Alg (as you suggest).

Cheers, Gabriel

Hi @goetz, thanks! this is great, I see no problem with removing these features. Actually, we had discussed earlier to remove them so that's one thing off our list!

CI Result FAILURE (hash 07e559d7)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20378]

OK thanks Goetz. so if these have not been used by offline then from the trigger point of view I don't see that there should be any problem removing them - sorry for the noise.

Cheers Mark

Waiting on resolution of https://its.cern.ch/jira/browse/ATEAM-652 for the diff-root problems, and https://sft.its.cern.ch/jira/browse/SPI-1708 for the gperftools/tcmalloc issue.

added 2 commits

• aa5ea6c5 - Remove unused pixel covariance correction for collimated tracks.
• a529f718 - Remove support for unused calorimeter ROIs and handling of b track candidates.

Compare with previous version

Removed dangling references from CMakeLists.txt

WARNING: big files (>100K) are found in the changeset

116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

This merge request affects 5 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetExample/InDetTrigRecExample
• InnerDetector/InDetRecTools/SiClusterOnTrackTool
• Tracking/TrkTools/TrkAmbiguityProcessor

Adding @goetz ,@sutt ,@amorley ,@gavrilen ,@sroe ,@nagano ,@jsandesa ,@bernius as watchers

Thanks for the fast feedback !

CI Result FAILURE (hash a529f718)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20383]

In the jenkins log I see e.g.:

...
ERROR: /cvmfs/sft.cern.ch/lcg/releases/LCG_98python3/gperftools/2.7/x86_64-centos7-gcc8-opt/lib/libtcmalloc.so does not exist
...
2020-09-14T145602 CEST TrigValSteering INFO     Test trig_data_v7Primaries_build finished with code 1 because the following required steps failed: ['athena']

Also other tests seem to fail in a similar way.

I fail reproduce the errors locally e.g.

Py:Athena            INFO using release [Athena-22.0.18] [x86_64-centos7-gcc8-opt] [master/4995f25ae19] -- built on [2020-09-13T2101]
Py:Athena            INFO including file "AthenaCommon/Preparation.py"
Py:Athena            INFO including file "AthenaCommon/Atlas.UnixStandardJob.py"
Py:Athena            INFO executing ROOT6Setup
Py:Athena            INFO executing CLI (-c) command: "menu="Physics_pp_v7_primaries";enableCostMonitoring=False;RunningRTT=True;"
...
Test trig_mc_v7Primaries_build finished with code 0 because all required steps were successful.

Also q431 ends successful.

Looks like a glitch to me.

Cheers, Götz