PixelCoralClientUtils+InDetCoolCoralClientUtils: Fix cppcheck warnings.

• Pass class instances by class reference, not by value.
• Prefer preincrement to postincrement for iterators.
• Remove redundant comparison.

WARNING: precompile check possibly found BANNED WORDS in the changeset. Please check to make sure they are acceptable (and conform to the CERN code of conduct) before proceeding with this MR

location of these words provided by git-keywords.lines.sh

InnerDetector/InDetConditions/PixelCoralClientUtils/PixelCoralClientUtils/CoralClient.hh: 102 103 126 127 128 ; InnerDetector/InDetConditions/PixelCoralClientUtils/src/CoralClient.cc: 270 284 285 432 435 557 559 570 572 573 577 581 590 939 940 941 948 1039 1043 1433 1436 1448 1450 1452 1453 1457 1461 1471 1524 1527 1530 1533 1539 1557 1570 1573 1590 1592 1594 1595 1599 1603 1613 1682 1685 1688 1691 1697 1715 1732 ;

end of git-keywords.lines.sh output

This merge request affects 2 packages:

• InnerDetector/InDetConditions/InDetCoolCoralClientUtils
• InnerDetector/InDetConditions/PixelCoralClientUtils

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 4ab3698e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20402]

Jenkins please retry a build

WARNING: precompile check possibly found BANNED WORDS in the changeset. Please check to make sure they are acceptable (and conform to the CERN code of conduct) before proceeding with this MR

location of these words provided by git-keywords.lines.sh

InnerDetector/InDetConditions/PixelCoralClientUtils/PixelCoralClientUtils/CoralClient.hh: 102 103 126 127 128 ; InnerDetector/InDetConditions/PixelCoralClientUtils/src/CoralClient.cc: 270 284 285 432 435 557 559 570 572 573 577 581 590 939 940 941 948 1039 1043 1433 1436 1448 1450 1452 1453 1457 1461 1471 1524 1527 1530 1533 1539 1557 1570 1573 1590 1592 1594 1595 1599 1603 1613 1682 1685 1688 1691 1697 1715 1732 ;

end of git-keywords.lines.sh output

This merge request affects 2 packages:

• InnerDetector/InDetConditions/InDetCoolCoralClientUtils
• InnerDetector/InDetConditions/PixelCoralClientUtils

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

CI Result SUCCESS (hash 4ab3698e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20416]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 405e3340

added sweep:ignore label