Skip to content
Snippets Groups Projects

Remove ATLAS_NOT_THREAD_SAFE ITrackSummaryTool methods

Merged Remove ATLAS_NOT_THREAD_SAFE ITrackSummaryTool methods
ATLAS-EGamma/athena:remove_thread_unsafe_method_move_remaining_const_cast_where_it_happens into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:remove_thread_unsafe_method_move_remaining_const_cast_where_it_happens into master
  • Remove the 3 methods marked as not-thread safe from ITrackSummaryTool
  • Remove them also from the TrackSummary implementation (obviously).
  • Fix TrkJiveXML/src/TrackRetriever.cxx to use the safe alternatives.
  • Move the const_cast that was happening in the above , inside , locally to where is needed to TrackScoringTool.cxx so we decide if the Track we pass is really const so we have a problem, or is non-const so we can trivial modify the code , to even just update.
  • Remove pragma GCC diagnostic ignored "-Woverloaded-virtual" not sure why we want to supress potential warning even if temporarily.
  • Update a bit comments
  • There are also some white space removal and bit of indentation on the header files as these have changed a bit for MT. I tried to leave the .cxx untouched as parts of it is the std old code.

I think the major cleanup of clients has happened already by @ssnyder and mentioning also @sroe

Edited by Christos Anastopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply