Skip to content
Snippets Groups Projects

Add dynamic lookup in AlgToChainTool

Merged Add dynamic lookup in AlgToChainTool
aporeba/athena:alg-chain-dynamic into master
Merged Aleksandra Poreba requested to merge aporeba/athena:alg-chain-dynamic into master

Add the dynamic lookup in AlgToChainTool. It looks for active chains in related Store (that is retrieved based on the context) and intersects the result with a static lookup set (based on the menu).

The tool was also moved to the TrigCompositeUtils package.

Examples of static and dynamic lookup results:

static dynamic
algorithm: IMFastCaloEMReco

menu: LS2_v1 		HLT_e3_etcut_L1EM3
HLT_e5_etcut_L1EM3
HLT_e7_etcut_L1EM7
HLT_e7_mu10_L1EM7_MU10
HLT_e7_mu12_L1EM7_MU10
HLT_g10_etcut_L1EM7
HLT_g15_etcut_L1EM12		 HLT_e3_etcut_L1EM3
HLT_e5_etcut_L1EM3
algorithm: TrigFastTrackFinder_MinBias (part of disabled chain)

menu: LS2_v1_TriggerValidation_mc_prescale 		HLT_mb_sptrk_L1RD0_FILLED -

Related to: ATR-19248

Tagging @mark

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tim Martin
  • Tim Martin
  • Tim Martin
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash f9c637be)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :o:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 5
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 55
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20483]

    • A
      Aleksandra Poreba @aporeba ·
      Author Developer
      Resolved by Aleksandra Poreba

      The CI failed because of

      In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/Root/AlgToChainTool.cxx:5: /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/TrigCompositeUtils/AlgToChainTool.h:13:10: fatal error: AthenaBaseComps/AthAlgTool.h: No such file or directory #include "AthenaBaseComps/AthAlgTool.h"

      but AthenaBaseComps lib is included in CMakeLists here so I have no idea why is failing. Should the code in AnalysisBase be independent of AthenaBaseComps?

      edit: I moved AthenaBaseComps to the component's, not the library's libraries link and it works fine locally (just like before)

      Edited by Aleksandra Poreba
  • Michele Faucci Giannelli added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Aleksandra Poreba added 2 commits

    added 2 commits

    • 22b25ffc - Review update
    • 8228d2fb - Remove AlgToChainTool from XAOD_STANDALONE

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigConfiguration/TrigConfigSvc
    • Trigger/TrigSteer/TrigCompositeUtils

    Adding @tamartin ,@mark ,@orlando ,@cmorenom ,@asonay as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 8228d2fb)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :o:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20526]

  • Gordon Watts
    Gordon Watts @gwatts ·
    Developer

    Looks like an include wasn't protected from AnalysisBase... :-(

    ===========================================================================
[ATLAS Nightly System]: logfile build.x86_64-centos7-gcc8-opt/BuildLogs/TrigCompositeUtils.log
===========================================================================
# Version: N/A
# CMake ---> /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.17.3/Linux-x86_64/bin/cmake -E make_directory /build2/ci-builds/master/AnalysisBase/build/AnalysisBase/x86_64-centos7-gcc8-opt/python/TrigCompositeUtils
# CMake ---> /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/bin/python2.7 /build2/ci-builds/master/AnalysisBase/build/AnalysisBase/Trigger/TrigSteer/TrigCompositeUtils/CMakeFiles/__init__pycGen.py
# CMake ---> /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DHAVE_64_BITS -DPACKAGE_VERSION="TrigCompositeUtils-00-00-00" -DPACKAGE_VERSION_UQ=TrigCompositeUtils-00-00-00 -DROOTCORE -DTrigCompositeUtilsLib_EXPORTS -DXAOD_ANALYSIS -DXAOD_STANDALONE -D__IDENTIFIER_64BIT__ -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfHLTUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgDataHandles -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccessInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccess -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinksSA -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventFormat -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigDecisionInterface -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigger -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigNavStructure -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include/python2.7 -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -o CMakeFiles/TrigCompositeUtilsLib.dir/Root/AlgToChainTool.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/Root/AlgToChainTool.cxx
# CMake ---> /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DHAVE_64_BITS -DPACKAGE_VERSION="TrigCompositeUtils-00-00-00" -DPACKAGE_VERSION_UQ=TrigCompositeUtils-00-00-00 -DROOTCORE -DTrigCompositeUtilsLib_EXPORTS -DXAOD_ANALYSIS -DXAOD_STANDALONE -D__IDENTIFIER_64BIT__ -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfHLTUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgDataHandles -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccessInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccess -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinksSA -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventFormat -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigDecisionInterface -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigger -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigNavStructure -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include/python2.7 -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -o CMakeFiles/TrigCompositeUtilsLib.dir/Root/TrigCompositeUtilsRoot.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/Root/TrigCompositeUtilsRoot.cxx
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/Root/AlgToChainTool.cxx:5:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/TrigCompositeUtils/AlgToChainTool.h:13:10: fatal error: AthenaBaseComps/AthAlgTool.h: No such file or directory
 #include "AthenaBaseComps/AthAlgTool.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: Failed to execute /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DHAVE_64_BITS -DPACKAGE_VERSION="TrigCompositeUtils-00-00-00" -DPACKAGE_VERSION_UQ=TrigCompositeUtils-00-00-00 -DROOTCORE -DTrigCompositeUtilsLib_EXPORTS -DXAOD_ANALYSIS -DXAOD_STANDALONE -D__IDENTIFIER_64BIT__ -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfHLTUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgDataHandles -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccessInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/xAODRootAccess -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinksSA -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventFormat -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigDecisionInterface -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigger -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigNavStructure -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/AnalysisBase/install/AnalysisBaseExternals/22.0.17/InstallArea/x86_64-centos7-gcc8-opt/include/python2.7 -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -o CMakeFiles/TrigCompositeUtilsLib.dir/Root/AlgToChainTool.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils/Root/AlgToChainTool.cxx (return code: 1)
Warning: the last line does not indicate that the package build is successful
  • Gordon Watts added review-pending-level-2 review-user-action-required labels and removed review-pending-level-1 label

    added review-pending-level-2 review-user-action-required labels and removed review-pending-level-1 label

  • Gordon Watts removed review-pending-level-2 label

    removed review-pending-level-2 label

  • Aleksandra Poreba added 1 commit

    added 1 commit

    • 4def0b79 - Remove AlgToChainTool from XAOD_STANDALONE

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigConfiguration/TrigConfigSvc
    • Trigger/TrigSteer/TrigCompositeUtils

    Adding @tamartin ,@mark ,@orlando ,@cmorenom ,@asonay as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 4def0b79)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :o:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :o:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 8
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20596]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply