support LRT in tau reconstruction (ATLTAU-1721)

Changed TauTrackFinder to use collection of standard

• LRT tracks by combining collections in a ConstDataVector

Closes ATLTAU-1721

added master label

added 1 commit

• a44c752d - support LRT in tau reconstruction (ATLTAU-1721)

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 2 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added Reconstruction Tau review-pending-level-1 labels

marked as a Work In Progress

added 1 commit

• 0f0d9e23 - support LRT in tau reconstruction (ATLTAU-1721)

Compare with previous version

added 1 commit

• 32bcaf45 - support LRT in tau reconstruction (ATLTAU-1721)

Compare with previous version

CI Result FAILURE (hash a44c752d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20591]

unmarked as a Work In Progress

This merge request affects 2 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

marked as a Work In Progress

unmarked as a Work In Progress

CI Result FAILURE (hash 32bcaf45)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20607]

added review-user-action-required label and removed review-pending-level-1 label

I guess failures like these are related to this MR:

RDOtoRDOTrigger 14:21:39 AthenaPoolConverter                     0   0     ERROR Failed to create persistent object: SG::ExcPointerNotInSG: The object referenced by a DataLink / ElementLink is not registered in StoreGate: 0xd069e900.
RDOtoRDOTrigger 14:21:39 AthenaPoolConverter                     0   0     ERROR FillRepRefs failed, key = HLT_xAOD__TauTrackContainer_TrigTauRecMergedTracksAux.
RDOtoRDOTrigger 14:21:39 StreamRDO.StreamRDOTool                 0   0     ERROR Could not fill Object Refs for DataObject (clid/key):1136575378 HLT_xAOD__TauTrackContainer_TrigTauRecMergedTracksAux.

Passing back to user to investigate.

marked as a Work In Progress

@martindl , there is an error running in TrigTauRecMerged_TauPreselection.

RDOtoRDOTrigger 13:53:36 ToolSvc.InDetTrigHoleSearchTool         0   0   WARNING No track parameters available for state of type measurement
RDOtoRDOTrigger 13:53:36 ToolSvc.InDetTrigHoleSearchTool         0   0   WARNING Don't run this tool on slimmed tracks!
RDOtoRDOTrigger 13:53:36 ToolSvc.InDetTrigHoleSearchTool         0   0   WARNING (last message!)
RDOtoRDOTrigger 13:53:36 TrigTauRecMerged_TauPreselection        0   0     ERROR std::exception caught: SG::ExcPointerNotInSG: The object referenced by a DataLink / ElementLink is not registered in StoreGate: 0xde470fc0.

Given the warning, it seems like we are losing some information in the track collection that is being passed to the creation a HITs map here. I am a bit puzzled since I believe the ConstDataVector is meant to point to the original tracks.